From owner-svn-ports-all@freebsd.org Thu Jun 23 22:37:41 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF860B7301E; Thu, 23 Jun 2016 22:37:41 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "apnoea.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3763E2FFD; Thu, 23 Jun 2016 22:37:40 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 15addffb TLS version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO; Thu, 23 Jun 2016 16:37:18 -0600 (MDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r417374 - in head: Mk Mk/Uses lang/php55 lang/php56 lang/php70 www/redaxo From: Adam Weinberger In-Reply-To: <83BA65E7C58012B7AA8A7962@atuin.in.mat.cc> Date: Thu, 23 Jun 2016 16:37:36 -0600 Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <307F483A-1ABE-4E02-A268-16F014D8DC44@adamw.org> References: <201606231319.u5NDJILd062527@repo.freebsd.org> <2400E414-B4B4-479C-BE0F-D804F1E0110A@adamw.org> <83BA65E7C58012B7AA8A7962@atuin.in.mat.cc> To: Mathieu Arnold X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 22:37:42 -0000 > On 23 Jun, 2016, at 15:36, Mathieu Arnold wrote: >=20 > +--On 23 juin 2016 13:46:41 -0600 Adam Weinberger = wrote: > |> On 23 Jun, 2016, at 7:19, Mathieu Arnold wrote: > |>=20 > |> Author: mat > |> Date: Thu Jun 23 13:19:17 2016 > |> New Revision: 417374 > |> URL: https://svnweb.freebsd.org/changeset/ports/417374 > |>=20 > |> Log: > |> Move bsd.php.mk to Uses/php.mk > |>=20 > |> PR: 210323 > |> Submitted by: mat > |> Exp-run by: antoine > |> Sponsored by: Absolight > |> Differential Revision: https://reviews.freebsd.org/D6867 > |=20 > |> # If you are building PHP-based ports in poudriere(8) with ZTS = enabled, > |> # add WITH_MPM=3Devent to /etc/make.conf to prevent build failures. > |=20 > | Does USES=3Dphp still have the above bug? If not, are there plans to = make > | ZTS detection work without assuming that everybody has apache = installed? >=20 > I did not change a thing, I'm modernizing the framework, I'm changing = how > things are done, but not what the things being done do. >=20 > (Also, I have absolutely no idea what ZTS is, or what the difference > between the different MPM are.) ZTS is a threading model for PHP. For a long time, bsd.php.mk has made = the strange decision to use the output of 'httpd -V' (from apache) to = determine whether PHP was built with ZTS. It uses that to determine = which directory to put modules into. The problem with that bizarre method is that if you don't have apache = installed, it puts modules into the wrong directory, and then all = further builds fail. In order to build PHP ports in poudriere, you have = to trick the system by using that WITH_MPM=3Devent line. There are a couple bugs open about it. 201193 and 207284 are both open = for it. php.mk should either put all PHP modules into one place (there's = really no point to making the module dir change), or figure out whether = PHP was built with ZTS by examining php.ini or the output of php-config. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org