From owner-svn-src-head@freebsd.org  Sat Oct 17 09:12:56 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF724A15422;
 Sat, 17 Oct 2015 09:12:56 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com
 [IPv6:2607:f8b0:400e:c03::230])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8020339C;
 Sat, 17 Oct 2015 09:12:56 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by payp3 with SMTP id p3so11848159pay.2;
 Sat, 17 Oct 2015 02:12:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=content-type:mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=GCANfHpF3m+HjdQmvVwxj4KA8VysWaCsg7TOyc1fu1g=;
 b=gH3mNfm2zJND7RdWkBpXd2mbEdJDE5OmQLETwebmgLhtiBX5ByG8bq9vSPwaiYy3K1
 aYm2OEKbRa+uHtMMYJoHW/YZlUAyS2LTLsUiIrXGnwBqM6fHR/yw5nHyYBaNkrdxyqF7
 +wY1YqODaToYAp51kGHhMWSacsGVKWYpTBoxi3os6EbQqAiuyq7ILS24yvX2/K+/5AG9
 SwKp2xodAPcmDWkcrcQSmhINMoDErL2YmSXp1Vp9sIPUTqWbVtVnJLoFC7pxKDN48kQD
 kbVup5mBxFKdWcZ0mG6tP5xqUTc3qodah4vIC0T4Wq4LkYEVWqkCiYH2rIYPKfi3gYxK
 CMMQ==
X-Received: by 10.68.143.4 with SMTP id sa4mr21631749pbb.111.1445073176183;
 Sat, 17 Oct 2015 02:12:56 -0700 (PDT)
Received: from ?IPv6:2601:601:800:126d:50a2:a8c0:9eec:851c?
 ([2601:601:800:126d:50a2:a8c0:9eec:851c])
 by smtp.gmail.com with ESMTPSA id kw10sm25482275pbc.25.2015.10.17.02.12.55
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sat, 17 Oct 2015 02:12:55 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: svn commit: r289450 - head/lib/libcam
From: NGie Cooper <yaneurabeya@gmail.com>
In-Reply-To: <201510170907.t9H97sgF066102@repo.freebsd.org>
Date: Sat, 17 Oct 2015 02:12:55 -0700
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <70C8FD63-73D9-4DE0-9FA4-DE928225F479@gmail.com>
References: <201510170907.t9H97sgF066102@repo.freebsd.org>
To: Garrett Cooper <ngie@FreeBSD.org>
X-Mailer: Apple Mail (2.2104)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Oct 2015 09:12:56 -0000


> On Oct 17, 2015, at 02:07, Garrett Cooper <ngie@FreeBSD.org> wrote:
>=20
> Author: ngie
> Date: Sat Oct 17 09:07:53 2015
> New Revision: 289450
> URL: https://svnweb.freebsd.org/changeset/base/289450
>=20
> Log:
>  Set dev->fd to -1 when calling cam_close_spec_device with a valid =
dev->fd
>  descriptor to avoid trashing valid file descriptors that access =
dev->fd at a
>  later point in time

That wasn=E2=80=99t a good description =E2=80=94 sorry :(.

The cam_close_spec_device API doesn=E2=80=99t free `struct cam_device =
*dev` by design, so something could reuse the structure, or call close =
on dev->fd (out of band), which could trash valid file descriptor(s) by =
accident.

Thanks!
-NGie=