From owner-cvs-src@FreeBSD.ORG  Sun Nov 16 23:07:28 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 717C216A4CE
	for <cvs-src@FreeBSD.org>; Sun, 16 Nov 2003 23:07:28 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 840FC4409A
	for <cvs-src@FreeBSD.org>; Sun, 16 Nov 2003 23:05:57 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 59068 invoked by uid 1000); 17 Nov 2003 07:05:59 -0000
Date: Sun, 16 Nov 2003 23:05:59 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: David Schultz <das@FreeBSD.org>
In-Reply-To: <20031117064021.6223416A4E3@hub.freebsd.org>
Message-ID: <20031116230357.K59017@root.org>
References: <20031117064021.6223416A4E3@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/nologin Makefile nologin.c nologin.sh
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2003 07:07:28 -0000

On Sun, 16 Nov 2003, David Schultz wrote:
>   Modified files:
>     sbin/nologin         Makefile
>   Added files:
>     sbin/nologin         nologin.c
>   Removed files:
>     sbin/nologin         nologin.sh
>   Log:
>   Reimplement nologin(8) as a C program.  This allows us to statically
>   link it at low cost and avoid environment poisoning attacks associated
>   with LD_LIBRARY_PATH.
>
>   Suggested by:   rwatson
>
>   Revision  Changes    Path
>   1.9       +9 -2      src/sbin/nologin/Makefile
>   1.1       +21 -0     src/sbin/nologin/nologin.c (new)
>   1.5       +0 -39     src/sbin/nologin/nologin.sh (dead)
>
> --- /dev/null	Sun Nov 16 22:40:21 2003
> +++ src/sbin/nologin/nologin.c	Sun Nov 16 22:39:38 2003
> @@ -0,0 +1,21 @@
> +/*-
> + * This program is in the public domain.  I couldn't bring myself to
> + * declare Copyright on a variant of Hello World.
> + */
> +
> +#include <sys/cdefs.h>
> +__FBSDID("$FreeBSD: /repoman/r/ncvs/src/sbin/nologin/nologin.c,v 1.1 2003/11/17 06:39:38 das Exp $");
> +
> +#include <sys/types.h>
> +#include <sys/uio.h>
> +#include <unistd.h>
> +
> +#define	MESSAGE	"This account is currently not available.\n"
> +
> +int
> +main(int argc, char *argv[])
> +{
> +
> +	write(STDOUT_FILENO, MESSAGE, sizeof(MESSAGE));
> +	_exit(1);
> +}

Shouldn't that be strlen(MESSAGE) since sizeof includes the terminating
'\0'?

I couldn't help pointing out a bug in a variant of Hello World.  ;-)

-Nate