From owner-freebsd-bugs@FreeBSD.ORG Sun Mar 22 08:20:04 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B925F106566C for ; Sun, 22 Mar 2009 08:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A726C8FC0C for ; Sun, 22 Mar 2009 08:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2M8K4mw045800 for ; Sun, 22 Mar 2009 08:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n2M8K43p045797; Sun, 22 Mar 2009 08:20:04 GMT (envelope-from gnats) Date: Sun, 22 Mar 2009 08:20:04 GMT Message-Id: <200903220820.n2M8K43p045797@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: bin/129566: commit references a PR X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2009 08:20:04 -0000 The following reply was made to PR bin/129566; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/129566: commit references a PR Date: Sun, 22 Mar 2009 08:14:12 +0000 (UTC) Author: ed Date: Sun Mar 22 08:14:01 2009 New Revision: 190254 URL: http://svn.freebsd.org/changeset/base/190254 Log: MFC r189542: Don't disable CR-to-NL translation when waiting for data to arrive. A difference between the old and the new TTY layer is that the new implementation does not perform any post-processing before returning data back to userspace when calling read(). sh(1)'s read turns the TTY into a raw mode before calling select(). This means that the first character will not receive any ICRNL processing. Inherit this flag from the original terminal attributes. Even though this issue is not present on RELENG_*, I'm MFCing it to make sh(1) in jails behave better. PR: bin/129566 Modified: stable/6/bin/sh/ (props changed) stable/6/bin/sh/miscbltin.c Modified: stable/6/bin/sh/miscbltin.c ============================================================================== --- stable/6/bin/sh/miscbltin.c Sun Mar 22 08:09:16 2009 (r190253) +++ stable/6/bin/sh/miscbltin.c Sun Mar 22 08:14:01 2009 (r190254) @@ -147,6 +147,7 @@ readcmd(int argc __unused, char **argv _ if (tcgetattr(0, &told) == 0) { memcpy(&tnew, &told, sizeof(told)); cfmakeraw(&tnew); + tnew.c_iflag |= told.c_iflag & ICRNL; tcsetattr(0, TCSANOW, &tnew); tsaved = 1; } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"