From owner-freebsd-hackers  Tue Jun 17 21:10:05 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id VAA26725
          for hackers-outgoing; Tue, 17 Jun 1997 21:10:05 -0700 (PDT)
Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA26687
          for <freebsd-hackers@freebsd.org>; Tue, 17 Jun 1997 21:09:52 -0700 (PDT)
Received: from awfulhak.demon.co.uk (localhost [127.0.0.1])
	by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id EAA01797;
	Wed, 18 Jun 1997 04:06:48 +0100 (BST)
Message-Id: <199706180306.EAA01797@awfulhak.demon.co.uk>
X-Mailer: exmh version 1.6.9 8/22/96
To: Mark Tinguely <tinguely@plains.NoDak.edu>,
        Stephen Roome <steve@visint.co.uk>, Robert Huff <rhuff@cybercom.net>,
        freebsd-hackers@freebsd.org, Ari Suutari <ari.suutari@ps.carel.fi>
Subject: pppd/natd
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 18 Jun 1997 04:06:48 +0100
From: Brian Somers <brian@awfulhak.org>
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

I've just applied a small patch that fixes the pppd/natd crash in
2.2 & -current.  The patch isn't the perfect solution, but it
will get things up and running for the time being.  I'll continue
to look into what's actually causing the garbage mbuf in the
first place.

If anybody *isn't* using cvsup or ctm, the patch is as follows:

diff -c -r1.19 ppp_tty.c
*** ppp_tty.c	1997/06/09 04:13:48	1.19
--- ppp_tty.c	1997/06/18 02:41:14
***************
*** 641,646 ****
--- 641,651 ----
      }
  
      s = spltty();	/* in case.. do not want netisrs to preempt us */
+ 
+     m = sc->sc_outm;
+     if (m && m->m_len < 0)
+         MFREE(m, sc->sc_outm);
+ 
      idle = 0;
      while (CCOUNT(&tp->t_outq) < PPP_HIWAT) {
  	/*

-- 
Brian <brian@awfulhak.org>, <brian@freebsd.org>
      <http://www.awfulhak.org>
Don't _EVER_ lose your sense of humour....