From owner-cvs-src-old@FreeBSD.ORG Wed Jun 9 16:43:03 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95707106566B for ; Wed, 9 Jun 2010 16:43:03 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8483D8FC13 for ; Wed, 9 Jun 2010 16:43:03 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o59Gh3Qk008175 for ; Wed, 9 Jun 2010 16:43:03 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o59Gh35t008174 for cvs-src-old@freebsd.org; Wed, 9 Jun 2010 16:43:03 GMT (envelope-from rrs@repoman.freebsd.org) Message-Id: <201006091643.o59Gh35t008174@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to rrs@repoman.freebsd.org using -f From: Randall Stewart Date: Wed, 9 Jun 2010 16:42:42 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet sctp_pcb.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2010 16:43:03 -0000 rrs 2010-06-09 16:42:42 UTC FreeBSD src repository Modified files: sys/netinet sctp_pcb.c Log: SVN rev 208953 on 2010-06-09 16:42:42Z by rrs Fix serveral bugs all having to do with freeing an sctp_inpcb: 1) Make sure not to remove the flag on the PCB until after the close() caller is back in control with the lock. Otherwise a quickly freeing assoc could kill the inpcb and cause a panic. 2) Make sure all calls to log_closing have not released the locks before calling the log function, we don't want the logging function to crash us due to a freed inpcb. 3) Make sure that when we get to the end, we release all locks (after removing them from view) and as long as we are NOT the inp-kill timer removing the inp, call the callout_drain() function so a racing timer won't later call in and cause a racing crash. MFC after: 1 week Revision Changes Path 1.108 +38 -22 src/sys/netinet/sctp_pcb.c