Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Aug 2023 01:23:39 GMT
From:      Kevin Bowling <kbowling@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 41e440c38147 - stable/13 - e1000: add missing parens in csum setup
Message-ID:  <202308040123.3741NdUv021282@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by kbowling:

URL: https://cgit.FreeBSD.org/src/commit/?id=41e440c38147dc37188b49cfdb051c33f056e6eb

commit 41e440c38147dc37188b49cfdb051c33f056e6eb
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2023-07-23 00:03:26 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2023-08-04 01:22:14 +0000

    e1000: add missing parens in csum setup
    
    Reported by:    rscheff
    Fixes:  4f9a44a215f8 e1000: Fix/enable IPv6 transmit checksum offload
    
    (cherry picked from commit 92fd2f39e5b1fd588fdc49a07d626273eb8f7539)
---
 sys/dev/e1000/em_txrx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/e1000/em_txrx.c b/sys/dev/e1000/em_txrx.c
index 1192286d1c9c..8b1d2817490f 100644
--- a/sys/dev/e1000/em_txrx.c
+++ b/sys/dev/e1000/em_txrx.c
@@ -291,7 +291,7 @@ em_transmit_checksum_setup(struct e1000_softc *sc, if_pkt_info_t pi,
 		*txd_upper |= E1000_TXD_POPTS_TXSM << 8;
 		*txd_lower = E1000_TXD_CMD_DEXT | E1000_TXD_DTYP_D;
 
-		if (csum_flags & CSUM_TCP | CSUM_IP6_TCP) {
+		if (csum_flags & (CSUM_TCP | CSUM_IP6_TCP)) {
 			tucso = hdr_len + offsetof(struct tcphdr, th_sum);
 			cmd |= E1000_TXD_CMD_TCP;
 		} else



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308040123.3741NdUv021282>