Date: Thu, 24 May 2018 08:25:37 +0200 From: Tobias Kortkamp <tobik@FreeBSD.org> To: =?utf-8?Q?Fernando=20Apestegu=C3=ADa?= <fernape@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470725 - in head/textproc/tkdiff: . files Message-ID: <1527143137.2894038.1383018096.245EB176@webmail.messagingengine.com> In-Reply-To: <201805232159.w4NLxYrK000782@repo.freebsd.org> References: <201805232159.w4NLxYrK000782@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 23, 2018, at 23:59, Fernando Apestegu=C3=ADa wrote: > Author: fernape > Date: Wed May 23 21:59:34 2018 > New Revision: 470725 > URL: https://svnweb.freebsd.org/changeset/ports/470725 >=20 > Log: > textproc/tkdiff: port improvements >=20=20=20 > * add DESKTOP_ENTRY > * add converters/base64 as BUILD_DEPENDS > * add icons >=20=20=20 > Also give maintainership to portmaster@bsdforge.com >=20=20=20 > PR: 228176 > Submitted by: portmaster@bsdforge.com > Approved by: tcberner (mentor) > Differential Revision: https://reviews.freebsd.org/D15480 >=20 > Added: > head/textproc/tkdiff/files/ > head/textproc/tkdiff/files/icon128.base64 (contents, props changed) > head/textproc/tkdiff/files/icon256.base64 (contents, props changed) > head/textproc/tkdiff/files/icon32.base64 (contents, props changed) > head/textproc/tkdiff/files/icon64.base64 (contents, props changed) > Modified: > head/textproc/tkdiff/Makefile >=20 > Modified: head/textproc/tkdiff/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/textproc/tkdiff/Makefile Wed May 23 21:45:50 2018 (r470724) > +++ head/textproc/tkdiff/Makefile Wed May 23 21:59:34 2018 (r470725) > @@ -3,28 +3,42 @@ >=20=20 > PORTNAME=3D tkdiff > PORTVERSION=3D 4.2 > -PORTREVISION=3D 1 > +PORTREVISION=3D 2 > CATEGORIES=3D textproc tk > MASTER_SITES=3D SF >=20=20 > -MAINTAINER=3D ports@FreeBSD.org > +MAINTAINER=3D portmaster@BSDforge.com > COMMENT=3D Tk frontend for diff(1) >=20=20 > LICENSE=3D GPLv2 > LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt >=20=20 > +BUILD_DEPENDS=3D base64>0:converters/base64 > + > WRKSRC=3D ${WRKDIR}/${PORTNAME}-unix >=20=20 > USES=3D tk:wrapper > NO_BUILD=3D yes >=20=20 > -PLIST_FILES=3D bin/tkdiff > +DESKTOP_ENTRIES=3D "Tkdiff" "Tk frontend for the diff command" \ > + "tkdiff" \ > + "tkdiff" "GNOME;GTK;Development;System;" \ > + false >=20=20 > +UNPACK=3D base64 -d > + > +PLIST_FILES=3D bin/tkdiff share/pixmaps/tkdiff.png share/pixmaps/ > tkdiff-256.png \ > + share/pixmaps/tkdiff-128.png share/pixmaps/tkdiff-64.png > + > post-patch: > ${FIND} ${WRKSRC} -type f | ${XARGS} \ > ${REINPLACE_CMD} -e '/^exec wish/s|wish|${WISH}|g' -e '/^exec tclsh/s| > tclsh|${TCLSH}|g' >=20=20 > do-install: > - @${INSTALL_SCRIPT} ${WRKSRC}/tkdiff ${STAGEDIR}${PREFIX}/bin > + ${INSTALL_SCRIPT} ${WRKSRC}/tkdiff ${STAGEDIR}${PREFIX}/bin > + ${UNPACK} ${FILESDIR}/icon256.base64 > ${STAGEDIR}${PREFIX}/share/ > pixmaps/tkdiff-256.png > + ${UNPACK} ${FILESDIR}/icon128.base64 > ${STAGEDIR}${PREFIX}/share/ > pixmaps/tkdiff-128.png > + ${UNPACK} ${FILESDIR}/icon64.base64 > ${STAGEDIR}${PREFIX}/share/ > pixmaps/tkdiff-64.png > + ${UNPACK} ${FILESDIR}/icon32.base64 > ${STAGEDIR}${PREFIX}/share/ > pixmaps/tkdiff.png >=20=20 > .include <bsd.port.mk> Hi, I have two questions. 1. Why not use base's `b64decode -r` instead of converters/base64? And this one goes to everyone: 2. print/jabref, misc/mc, editors/openoffice-devel, etc. seem to have binary files in files/*.png. Can we add new ones or is it forbidden now? It seems weird to have to base64 encode icons and decode them during the build.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1527143137.2894038.1383018096.245EB176>