Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 May 2018 08:29:54 +0000
From:      bugzilla-noreply@freebsd.org
To:        fs@FreeBSD.org
Subject:   [Bug 213507] [msdosfs]: Prevent occasional directory corruption while extending it to another cluster
Message-ID:  <bug-213507-3630-DbhCIO7jKA@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-213507-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-213507-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213507

--- Comment #19 from Damjan Jovanovic <damjan.jov@gmail.com> ---
I am still doing my test.

That isn't the only vfs_bio_clrbuf() in msdosfs. IMHO we really should "find
all the incomplete brelse() calls".

How do "incomplete brelse() calls" work? What is the general rule? Accordin=
g to
that UFS patch it seems to be: a buf's b_data can only be changed if you
subsequently bwrite() it, or brelse() it with b_flags containing B_INVAL |
B_RELBUF | B_NOCACHE and not containing B_ASYNC | B_CACHE. If bwrite() fails
you must brelse() the buf with those flags instead. Is that right?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-213507-3630-DbhCIO7jKA>