From owner-freebsd-stable@FreeBSD.ORG Mon Oct 22 17:01:56 2012 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 40C33567 for ; Mon, 22 Oct 2012 17:01:56 +0000 (UTC) (envelope-from mailer-daemon@vniz.net) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id AD3118FC16 for ; Mon, 22 Oct 2012 17:01:55 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so1131347bkc.13 for ; Mon, 22 Oct 2012 10:01:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:disposition-notification-to:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:openpgp :content-type:content-transfer-encoding:x-gm-message-state; bh=K1ISnGEgtumL0hoDmxLIGlMpVAgesoHBa7LQZpWXS1M=; b=NMmleQ4UGiQVSJrDZl3SKhiN9jNsY2C0oitcsIGUG1iYVWl4lZS57GuyXy8vGq032H r3GCKrRCFUoXpQnNxdoKnVRtDyEofWfutJ4b3trM9VKulP0HxwKkzeCdt/HViVq/N6jp W2wN9fHiPpure1BRnXHaLP1mrNVxCTmA49KuJh45UQEG2V9mRBvvOf09qNlFGjNnDS2W Bl5K03nQiTWhQ+JxjSkn1UcMhP2wPQhZUKyXhRaCuq5W0nCdiU5LB8wtA/w2dmcJBeuR WTSOV9OLbJ+nV+Y7ctMC0+s2nHguZzKphL71RLTA8LQgxs8eSZ1WZ4JoSD2vc9EDzyXY KjEA== Received: by 10.204.147.139 with SMTP id l11mr2947412bkv.100.1350925314318; Mon, 22 Oct 2012 10:01:54 -0700 (PDT) Received: from [192.168.1.2] ([89.169.140.97]) by mx.google.com with ESMTPS id 9sm4238998bkq.13.2012.10.22.10.01.52 (version=SSLv3 cipher=OTHER); Mon, 22 Oct 2012 10:01:53 -0700 (PDT) Message-ID: <50857C01.8050500@freebsd.org> Date: Mon, 22 Oct 2012 21:01:53 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: John Baldwin Subject: Re: ${CTFCONVERT_CMD} expands to empty string References: <5081F92F.8040004@freebsd.org> <508317A4.2060800@freebsd.org> <5084927C.1070101@freebsd.org> <201210221142.06889.jhb@freebsd.org> <50856F6F.40204@freebsd.org> <50857831.1070603@freebsd.org> In-Reply-To: <50857831.1070603@freebsd.org> OpenPGP: id=964474DD Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-Gm-Message-State: ALoCoQnyy7mN+f6KKCPGyR9mUi5nNxI9uzVyqNuWo/ObAOb6Km0m+IkdfNPDhwXVfBb86GNfwimo Cc: stable@freebsd.org, freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 17:01:56 -0000 All that happens because this commit is not merged into stable-9. Do you plan to mere it by yourself? r228157 | fjoe | 2011-11-30 22:07:38 +0400 (ср, 30 ноя 2011) | 10 lines - Fix segmentation fault when running "+command" when run with -jX -n due to Compat_RunCommand() being called with `cmd' that is not on the node->commands list - Make ellipsis ("..." command) handling consistent: check for "..." command in job make after variables expansion to match compat make behavior - Fix empty command handling (after variables expansion and @+- modifiers are processed): now empty commands are ignored in compat make and are not printed in job make case - Bump MAKE_VERSION to 5-2011-11-30-0 On 22.10.2012 20:45, Andrey Chernov wrote: > And simple test case proving that make v9201206140 dislike empty commands. > Makefile: > ------------------------------------------------ > CTFCONVERT_CMD= > all: > echo ${MAKE_VERSION} > ${CTFCONVERT_CMD} > echo b > ------------------------------------------------ >> make > echo 9201206140 > 9201206140 > ${CTFCONVERT_CMD} expands to empty string > echo b > b > > On 22.10.2012 20:08, Andrey Chernov wrote: >> On 22.10.2012 19:42, John Baldwin wrote: >>> On Sunday, October 21, 2012 8:25:32 pm Andrey Chernov wrote: >>>> Those lines cause this error: >>>> .if ${MK_CTF} != "no" >>>> CTFCONVERT_CMD= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} >>>> .elif ${MAKE_VERSION} >= 5201111300 >>>> CTFCONVERT_CMD= >>>> .else >>>> CTFCONVERT_CMD= @: >>>> .endif >>>> >>>> My make version is 9201206140 >>>> So, either the check for >= 5201111300 is incorrect or change for empty >>>> make variables expansion is not merged into stable-9 >>> >>> I can't reproduce this doing a buildworld of a stable/9 checkout on a 9.0- >>> stable machine btw. What exact contents of /etc/src.conf and commands are you >>> using to reproduce this? >>> >>> I also can't find the string "empty string" in the output of my stable/9 >>> 'make universe' build before I committed this. >>> >> >> /etc/src.conf: >> WITHOUT_AMD=yes >> WITHOUT_APM=yes >> WITHOUT_ATM=yes >> WITHOUT_AUDIT=yes >> WITH_BSD_GREP=yes >> WITHOUT_BLUETOOTH=yes >> WITHOUT_BSNMP=yes >> WITHOUT_CDDL=yes >> WITHOUT_CLANG=yes >> WITHOUT_CTM=yes >> WITHOUT_FORTRAN=yes >> WITHOUT_GPIB=yes >> WITHOUT_GPIO=yes >> WITHOUT_GSSAPI=yes >> WITHOUT_I4B=yes >> WITH_IDEA=yes >> WITHOUT_IPFILTER=yes >> WITHOUT_IPX=yes >> WITHOUT_NCP=yes >> WITHOUT_NIS=yes >> WITHOUT_KERBEROS=yes >> WITHOUT_MAILWRAPPER=yes >> WITHOUT_PF=yes >> WITHOUT_PMC=yes >> WITHOUT_PROFILE=yes >> WITHOUT_RCMDS=yes >> WITHOUT_SLIP=yes >> WITHOUT_WIRELESS=yes >> >> I got that useless line _each_ .c file compiles. Example commands: >> cd /usr/src/usr.bin/make >> make clean >> make >> I got: >> cc -O2 -pipe -march=pentium4 -I/usr/src/usr.bin/make >> -DMAKE_VERSION=\"9201206140\" -DDEFSHELLNAME=\"sh\" -std=gnu99 >> -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W >> -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes >> -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch >> -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline >> -Wnested-externs -Wredundant-decls -Wold-style-definition >> -Wno-pointer-sign -c /usr/src/usr.bin/make/arch.c >> ${CTFCONVERT_CMD} expands to empty string >> ...etc... on each file. >> >