From owner-p4-projects@FreeBSD.ORG  Wed Apr 28 11:49:56 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E59CC1065670; Wed, 28 Apr 2010 11:49:55 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AA30D106564A
	for <perforce@freebsd.org>; Wed, 28 Apr 2010 11:49:55 +0000 (UTC)
	(envelope-from mav@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 97D978FC12
	for <perforce@freebsd.org>; Wed, 28 Apr 2010 11:49:55 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o3SBntQL098605
	for <perforce@freebsd.org>; Wed, 28 Apr 2010 11:49:55 GMT
	(envelope-from mav@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o3SBntuk098603
	for perforce@freebsd.org; Wed, 28 Apr 2010 11:49:55 GMT
	(envelope-from mav@freebsd.org)
Date: Wed, 28 Apr 2010 11:49:55 GMT
Message-Id: <201004281149.o3SBntuk098603@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	mav@freebsd.org using -f
From: Alexander Motin <mav@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 177431 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2010 11:49:56 -0000

http://p4web.freebsd.org/@@177431?ac=10

Change 177431 by mav@mav_mavbook on 2010/04/28 11:49:06

	Disable ATAPI DMA for SoCs. It is not always working, while PIO
	seems working better.

Affected files ...

.. //depot/projects/scottl-camlock/src/sys/dev/mvs/mvs.c#17 edit

Differences ...

==== //depot/projects/scottl-camlock/src/sys/dev/mvs/mvs.c#17 (text+ko) ====

@@ -701,7 +701,7 @@
 					}
 				}
 			}
-device_printf(dev, "err slot %d port %d\n", ccs, port);
+//device_printf(dev, "err slot %d port %d\n", ccs, port);
 			mvs_requeue_frozen(dev);
 			for (i = 0; i < MVS_MAX_SLOTS; i++) {
 				/* XXX: reqests in loading state. */
@@ -1135,6 +1135,7 @@
 		/* Use ATAPI DMA only for commands without under-/overruns. */
 		if ((ccb->ccb_h.flags & CAM_DIR_MASK) != CAM_DIR_NONE &&
 		    ch->curr[ccb->ccb_h.target_id].mode >= ATA_DMA &&
+		    (ch->quirks & MVS_Q_SOC) == 0 &&
 		    (cdb[0] == 0x08 ||
 		     cdb[0] == 0x0a ||
 		     cdb[0] == 0x28 ||