From nobody Mon Feb 17 20:22:07 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YxYwc5bcrz5p6d5; Mon, 17 Feb 2025 20:22:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YxYwc4xQdz3vjb; Mon, 17 Feb 2025 20:22:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739823728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0TaHSB4T7zLgGQoFV/80VZYZQ6Abb5D9zLq7Aya4P8=; b=fUTQZb/UTjIkFRHAisQSh/CIde99cvCcZ4hNzpgxCIonq/kOQHagRm9yCWXLrylkbd/wD6 zCVzR38o+mu9TXR59zUbtOBqlsi9Paa0QZhWtym+cuIEEkR6IOcaq+KgSw4yQo366K9P0L ggMkGT+g73HwiK0ygwKYkwHSnuVR4XXmTe9PCYMBLdTmupJsawGZEmGgQsh0LcHKAG4I3D e1oM7REs47C5LmBI4/owRb+yBykNWwAGl6dc+kOZY4cLUfh8roTFqjex+Pbyvvs2Ez8YiT NJ34OOnlPbu70w537acH2DxKdMrjMgkrNb5QoTUCQaBDhh9pufoLUR25n6l/DA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739823728; a=rsa-sha256; cv=none; b=roiUl/YrAm22WHxy+yMVSRwTHPcybZqNMVbO6nJjMVuMpBouFDVx/Yz8ou5JO3Q5EFbVe/ i4Eq//53NO6SPrUH/5qvPDw2YE3LH8kcllgMdbA1W4tWvvz390blAvv5/W+x/O65aAuMFb zMdRm3vGuoyC663GxddLJHGcKbR+sBsLOBDxb1WjFZIRLXMg5qdxbOyM1BxXRY/hC4moIS 71iDial/rw8wCmv4Iejsze/zAp/onjIp1J8d29DjF2uIEhgVar0P2ArU5JZ1BfOUXwsFVy WmHjE9+zPcQrZqk9sMb2cNVgWP6fZNJw6mwm+aTyxIDhGSV8hSnYcrFkmWNbSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739823728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0TaHSB4T7zLgGQoFV/80VZYZQ6Abb5D9zLq7Aya4P8=; b=eav7KUULDKxK8rtQ3AOqlCuHwM3QKApKOBHtPw9u5sHkSV8r4WR8YRshK04WLTKwGCZ/vD 1dQkCuawZC8AwlOsUXWMWQJIBtH7yMkKon6o+aTbPsdA4h14Qmg+1iLhyNe6ZWT0gduzmM h2PoJNucqA85mRZW8uBFuUlPUQYL2dcIXDDtw3aNwsiDtYm27xwF2xxXUz9W60uMqXudNY kgTStpV6lrGIUj+7TnPGSlUsIyQr9DsRilgAXys5jU9T2nwSwibrQNF5AO1RRaskM2oKpR qErWIeuh3ntMv9oa5J4s8l/XLsFTDaXlraj4eC9iVyIEerurssilhdfdfFEeEg== Received: from [IPV6:2601:5c0:4200:b830:88ac:d422:574d:64aa] (unknown [IPv6:2601:5c0:4200:b830:88ac:d422:574d:64aa]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YxYwc341Cz9pq; Mon, 17 Feb 2025 20:22:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <06849674-d51f-4a20-9ddb-687e29ece68e@FreeBSD.org> Date: Mon, 17 Feb 2025 15:22:07 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 7e7f88001d7d - main - pf: use time_t for storing time_t values Content-Language: en-US To: Kristof Provost Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202502141750.51EHoOFm061342@gitrepo.freebsd.org> <5c019c51-949b-4255-bc44-926ac973a1af@FreeBSD.org> <1B3E8B07-037B-4DA9-A8D7-81F866078A39@FreeBSD.org> From: John Baldwin In-Reply-To: <1B3E8B07-037B-4DA9-A8D7-81F866078A39@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/17/25 12:08, Kristof Provost wrote: > On 17 Feb 2025, at 16:24, John Baldwin wrote: >> On 2/14/25 12:50, Kristof Provost wrote: >>> The branch main has been updated by kp: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=7e7f88001d7dfec83cd7568369be6a587d4a51ff >>> >>> commit 7e7f88001d7dfec83cd7568369be6a587d4a51ff >>> Author: Kristof Provost >>> AuthorDate: 2025-02-07 10:29:26 +0000 >>> Commit: Kristof Provost >>> CommitDate: 2025-02-14 17:47:52 +0000 >>> >>> pf: use time_t for storing time_t values >>> No change to the underlying type, so no ABI change. >>> We define __time_t as uint64_t if __LP64__, otherwise >>> uint32_t, >>> and only define __LP64__ if long is 64 bits. >>> In other words: __time_t == long. >>> ok henning@ deraadt@ >>> Obtained from: OpenBSD, guenther , >>> 6c1b69a0ff >>> Sponsored by: Rubicon Communications, LLC ("Netgate") >>> Differential Revision: https://reviews.freebsd.org/D48963 >> >> This is an ABI change on non-i386 32-bit platforms in FreeBSD since >> they >> all use a 64-bit type for time_t that is not the same size as long. >> Not >> sure if the ABI change matters on FreeBSD though? >> > It wasn’t intended to be an ABI change, hence the commit message. It > appears that’s only correct for x86 though. I assumed the commit message was from OpenBSD as the comments about defining time_t conditional on __LP64__ are not correct on FreeBSD (each arch defines a __time_t in , though amd64 and i386 share x86/include/_types.h which does use an #ifdef that perhaps is the source of confusion?) > So we’re only talking about armv7 and ppc32, if I’m not forgetting > anything. The former is on the removal list already, and the latter .. > well, I don’t know how many users there are. Both are likely to be > embedded platforms where the ABI change is going to be even less > relevant (because it really only matters if the kernel and userspace are > not updated together, and these are going to be embedded devices that > are far more likely to have everything updated simultaneously).> > So I’m unsure about what to do. I can revert this and we can just > carry this (trivial) diff to OpenBSD forever, or we can ignore the ABI > breakage given the above. I’m not inclined to do anything more > involved though. > > Do you have any thoughts? To be clear, armv7 is planned to be around a bit longer than other 32-bit platforms. That said, 32-bit plaforms are all Tier 2, so an ABI breakage in main is not necessarily the end of the world. Presumably these structures aren't used much in ports but only in base system tools anyway? (That is what my question about the ABI change mattering was trying to allude to) I agree with Justin that this is not something to MFC. -- John Baldwin