From owner-svn-src-head@freebsd.org Thu Aug 16 16:48:11 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB961106DF1D; Thu, 16 Aug 2018 16:48:10 +0000 (UTC) (envelope-from ambrisko@ambrisko.com) Received: from mail.ambrisko.com (mail.ambrisko.com [70.91.206.90]) by mx1.freebsd.org (Postfix) with ESMTP id 25F398CBF3; Thu, 16 Aug 2018 16:48:10 +0000 (UTC) (envelope-from ambrisko@ambrisko.com) X-Ambrisko-Me: Yes Received: from server2.ambrisko.com (HELO internal.ambrisko.com) ([192.168.1.2]) by ironport.ambrisko.com with ESMTP; 16 Aug 2018 09:56:35 -0700 Received: from ambrisko.com (localhost [127.0.0.1]) by internal.ambrisko.com (8.14.7/8.15.2) with ESMTP id w7GGm9H4054879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 16 Aug 2018 09:48:09 -0700 (PDT) (envelope-from ambrisko@ambrisko.com) Received: (from ambrisko@localhost) by ambrisko.com (8.14.7/8.15.2/Submit) id w7GGm9IH054878; Thu, 16 Aug 2018 09:48:09 -0700 (PDT) (envelope-from ambrisko) Date: Thu, 16 Aug 2018 09:48:09 -0700 From: Doug Ambrisko To: Justin Hibbits Cc: Ravi Pokala , Doug Ambrisko , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337913 - in head/sys: dev/ipmi modules/ipmi Message-ID: <20180816164809.GA54556@ambrisko.com> References: <201808161559.w7GFx3pg061595@repo.freebsd.org> <20180816112331.2d6d638f@ralga.knownspace> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180816112331.2d6d638f@ralga.knownspace> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 16:48:11 -0000 On Thu, Aug 16, 2018 at 11:23:31AM -0500, Justin Hibbits wrote: | Woops, my fault way back when I made powerpc64's IPMI OPAL buildable as | a module. Can't believe I had i386 twice in there. I was glad it was a simple fix ... the panic issue I'm not so happy about since I can't fix it on a live machine with a klunload/kldload :-( it was good to expose the panic bug to get that fixed for next time! Thanks, Doug A. | On Thu, 16 Aug 2018 09:11:01 -0700 | Ravi Pokala wrote: | | > The confluence of these two issues is that on amd64 ipmi.ko loads, | > but doesn't attach to the BMC or create /dev/ipmi, and that the | > kernel panics when trying to unload. Right? | > | > If so, that's exactly the issue I hit on Monday, but didn't get a | > chance to triage. Thanks! | > | > -Ravi | > | > -----Original Message----- | > From: on behalf of Doug Ambrisko | > Date: 2018-08-16, Thursday at 08:59 | > To: , , | > Subject: svn commit: r337913 - in | > head/sys: dev/ipmi modules/ipmi | > | > Author: ambrisko | > Date: Thu Aug 16 15:59:02 2018 | > New Revision: 337913 | > URL: https://svnweb.freebsd.org/changeset/base/337913 | > | > Log: | > Fix a module Makefile error on amd64 so the IPMI HW interfaces are | > built. When the module is being unloaded and no HW interfaces were | > created don't clean up. This was exposed by the amd64 module build | > issue. | > | > Modified: | > head/sys/dev/ipmi/ipmi.c | > head/sys/modules/ipmi/Makefile | > | > Modified: head/sys/dev/ipmi/ipmi.c | > ============================================================================== | > --- head/sys/dev/ipmi/ipmi.c Thu Aug 16 15:54:12 2018 | > (r337912) +++ head/sys/dev/ipmi/ipmi.c Thu Aug 16 15:59:02 | > 2018 (r337913) @@ -1053,6 +1053,8 @@ ipmi_unload(void *arg) | > int count; | > int i; | > | > + if (ipmi_devclass == NULL) | > + return; | > if (devclass_get_devices(ipmi_devclass, &devs, &count) != 0) | > return; | > for (i = 0; i < count; i++) | > | > Modified: head/sys/modules/ipmi/Makefile | > ============================================================================== | > --- head/sys/modules/ipmi/Makefile Thu Aug 16 15:54:12 | > 2018 (r337912) +++ head/sys/modules/ipmi/Makefile Thu | > Aug 16 15:59:02 2018 (r337913) @@ -7,7 +7,7 @@ | > KMOD= ipmi | > SRCS= ipmi.c | > SRCS+= bus_if.h device_if.h | > -.if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "i386" | > +.if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64" | > SRCS+= ipmi_kcs.c ipmi_smic.c ipmi_smbios.c ipmi_ssif.c | > SRCS+= ipmi_acpi.c ipmi_isa.c ipmi_pci.c ipmi_smbus.c | > SRCS+= opt_acpi.h | > | > | > | > |