From owner-freebsd-arch@FreeBSD.ORG Thu Nov 15 13:27:35 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 90B2F502; Thu, 15 Nov 2012 13:27:35 +0000 (UTC) (envelope-from giovanni.trematerra@gmail.com) Received: from mail-qc0-f182.google.com (mail-qc0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0D2A18FC0C; Thu, 15 Nov 2012 13:27:34 +0000 (UTC) Received: by mail-qc0-f182.google.com with SMTP id k19so1277747qcs.13 for ; Thu, 15 Nov 2012 05:27:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=kjp9lZN2nPy3aTeCO34QPAJrwBvbhN2Gcdqfz/q9588=; b=MelmHWl1d6Ri1A+qjO/0uSUpCfC8YkuYIL12cqmGtERcuuG+89aJ4Iz//rHTQVIQEG 7HIZN1leMQyrDq0H7ymD5KpszHo5Qkow0Py2J88liumlEJadAv9MCYu0dNedvgyR0IqF Z6THrbrqwkEjMTcqXghg0yjMwVJ1Lsj7uU/KOMYS1jmF/sYZFAXdJXgpUfoJ7Wr8kNgA 2oMa1ODCxilaEZnJVzW3HPVA+/CmoeTSfD4vJrHAcOgT+aZiJCaucrFreofYdiGDSYVk 5rXpjlEibKhdoheRuNUX1izGEhqXmGCNG7OouSlIXc4cvHFUkBa7jS4g9pIVPLgoJpTI 3b4A== MIME-Version: 1.0 Received: by 10.224.194.134 with SMTP id dy6mr1044256qab.81.1352986053363; Thu, 15 Nov 2012 05:27:33 -0800 (PST) Received: by 10.229.117.1 with HTTP; Thu, 15 Nov 2012 05:27:33 -0800 (PST) In-Reply-To: References: Date: Thu, 15 Nov 2012 14:27:33 +0100 Message-ID: Subject: Re: [RFQ] make witness panic an option From: Giovanni Trematerra To: Adrian Chadd Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-hackers@freebsd.org" , freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2012 13:27:35 -0000 On Thu, Nov 15, 2012 at 7:15 AM, Adrian Chadd wrote: > Hi all, > > When debugging and writing wireless drivers/stack code, I like to > sprinkle lots of locking assertions everywhere. However, this does > cause things to panic quite often during active development. > > This patch (against stable/9) makes the actual panic itself > configurable. It still prints the message regardless. > This has allowed me to sprinkle more locking assertions everywhere to > investigate whether particular paths have been hit or not. I don't > necessarily want those to panic the kernel. > > I'd like everyone to consider this for FreeBSD-HEAD. I really do think that is a very bad idea. When a locking assertion fails you have just to stop your mind and think what's wrong, no way to postpone on this. -- Gianni