From nobody Thu Dec 11 20:44:28 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dS4MJ6Twpz6KLLm for ; Thu, 11 Dec 2025 20:44:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dS4MJ3W3jz3cH6 for ; Thu, 11 Dec 2025 20:44:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765485868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dUcUVb3Dp6Z0yKJG30o0K99iqhiivRUbP0ABbhgNlE0=; b=DjwGoX4nWnYMOP8UmfsHvNa4e0CDLZqI5T/QCFRR8gWi9s30M/Olc7HxM5fwb9yVj2O/IR tLpYL9FVci24TqZu4hYh8958AtgBMfiy+tCdL/Z3w0IduVWiQ4sZlOUCWmBD2Ce84MMlpQ 7rdU1Mh9HgKpRrs2YypXx+fpTP092RX/qQ/HhReD4oqSvAVS1DSr+6OecAIL5F7HbwqfRQ lHLIWrn8NXOVPBXP8aUsE6Iol3ZahJjErXx9qON2kD3u8rhVJHNZCc2+NvPGh2hkVChsGU 35+0fu+KBwp3y+pKtY++ba8e4Jx/jaSp5r8H9z5gIsipnYPUkQJ0fXD4lUUhVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765485868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dUcUVb3Dp6Z0yKJG30o0K99iqhiivRUbP0ABbhgNlE0=; b=b6946lz/ADcylDEuFond+uvDsa36G1wKPbvq3ywhjgWSL1weGERRDiaSqD4kiiQYA1gTWN srysvF/3PI5HLUbTd2HYBIMpnnXbddzGKCOvMZ3ZVP6IYvFIaWtebDjtcJ5q+0MTnL2sqV AamD7xkGjK7RmScGsOkFQsARfXQ5Jm+911mVqxTtkfHAX+TFanMpWSpPolC0XDj4I6AbDz mmFikPs7bM/czHrnSN9+LpxdUxyr7o8wXZavj7pE4PJDNzCDgmBEzqx2EUuEYRO8RLnXou 3NA0N0jzv/RXdqJdEn3fZ+1mAh7lTegUcieMWs0c7orx7P/RwfJJOk1wrUyOxg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765485868; a=rsa-sha256; cv=none; b=t82o/O11uU3E/O1rooGM4Aj33C9PzYg2IDt5Wq5pe2gLxA32WwV1inxAhtb1gwcFjedtD2 XUpY5Yj3z07xRaG5cNEJC/dfzes5ZXDT+Lz+4FeiHmJn44LvpvHhL47EEXp4pJ33RuNLgY BABXxD/dWLOIw9dmz6nkst4w9H6wUhxHRBnk0fbg9syyNGoqiJ+JRv81BHdjMJ11WqDiyN FIdOoVpIh9R/EZutqNFh0AudGMX3fSu0yKwJrLrlhHh27rLOKowgaGHnPF30U2mc9gu3OY b6r+HI65+34yYMP8fBeiZMEquZ53tqbyuF4q5yh4mf3xRsXNQ9+zi4BdsT5aTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dS4MJ2pShzmll for ; Thu, 11 Dec 2025 20:44:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31b37 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 11 Dec 2025 20:44:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: f2a21b1b483c - stable/14 - e1000: Don't enable ASPM L1 without L0s List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f2a21b1b483ce8c54adac59e254611dad5c25fd9 Auto-Submitted: auto-generated Date: Thu, 11 Dec 2025 20:44:28 +0000 Message-Id: <693b2d2c.31b37.45741c40@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=f2a21b1b483ce8c54adac59e254611dad5c25fd9 commit f2a21b1b483ce8c54adac59e254611dad5c25fd9 Author: Kevin Bowling AuthorDate: 2025-11-21 05:47:03 +0000 Commit: Kevin Bowling CommitDate: 2025-12-11 20:44:09 +0000 e1000: Don't enable ASPM L1 without L0s Reporter noted packet loss with 82583. NVM is down level. The errata docs mention disabling this, which should be the firmware default, so I am not sure why we were enabling this bit. Linux and OpenBSD have the same issue, while NetBSD got it right. Reported by: Codin Tested by: Codin (cherry picked from commit 2ead091715dee327b3e00bc9840e1a95827b8e82) --- sys/dev/e1000/e1000_82571.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/e1000/e1000_82571.c b/sys/dev/e1000/e1000_82571.c index e8970adf996f..650169663f56 100644 --- a/sys/dev/e1000/e1000_82571.c +++ b/sys/dev/e1000/e1000_82571.c @@ -1118,7 +1118,8 @@ static s32 e1000_init_hw_82571(struct e1000_hw *hw) case e1000_82574: case e1000_82583: reg_data = E1000_READ_REG(hw, E1000_GCR); - reg_data |= E1000_GCR_L1_ACT_WITHOUT_L0S_RX; + /* 82574 Errata 25, 82583 Errata 12 */ + reg_data &= ~E1000_GCR_L1_ACT_WITHOUT_L0S_RX; E1000_WRITE_REG(hw, E1000_GCR, reg_data); break; default: