From nobody Sat Sep 20 22:41:46 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cTkrj659yz68W9S for ; Sat, 20 Sep 2025 22:41:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cTkrj4rqBz3ZNd for ; Sat, 20 Sep 2025 22:41:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758408117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P0t7eFsldAY5lTHLYdMcC1BfgCvn2+GDdJ4vAV6t7RM=; b=vEDxMm6YjXVk+/FTUZcDvEjnj0AA+kofsGJrLb2AeQ1APpj/3RIQeNEaVA4wxavertUO7E hZ/f/2MGkIRUM8MGongh9LwqAJGTUBRkWzgEEKYYiFe+7GpXji+yRSP7JqQkp6Nhkt/CP3 +Oo7PnpcEZcrMNkToMqZVX+411jOorkhOq/8u8epW6tVtTDnmdcyLX8+15VcKpmwrYVxFZ Ykn9/BVys2g0XOVRKrC4f+d6K1HhdGLgl6bSVt3gUzwnecKvNg3xgHj12i5yoJS/DFSwTm /JrkaxrE8BjDl+PLuupQLm/4EdCwEvbwWhx2bsfUudX1AhoBvn7n7fOqkjC4Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758408117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P0t7eFsldAY5lTHLYdMcC1BfgCvn2+GDdJ4vAV6t7RM=; b=p1tQQsLokSIlJqEc6jW9oVeDNg2mXvXa7fStmitkXdXoOiKA6XFtpHw9rNv7Q0c0lTVGyf M7a5m7ZnueTCghZ04Okb/ebs6Dq6DwaiTJ7M5MJV0U0/2rbtP/kkMAxGqEwCXv+Zh8Z9Vj rbxRx8b2D+uGEB3X67+OT929GDnweH9hu69vIQ4CQc9ynGBV9C8H8brScv/sjj2guGUQjw h/K/LKoS/C1GKJgO5C2oj/6pF7RzLC7PSsJ/QzzeNEsJlBttiPgsrgklWohQPopl9ZEy/2 pP7pWJ4aQTRgAmsrMMgWkC6d2HpNG3t/m3eg9h7/j/OrPkXH2/iaPucT2dwveA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758408117; a=rsa-sha256; cv=none; b=JGYLT1F+DJ+AaCoqtgKL9hHdfV4OL0y0QeVMxxbTBwF7PD4MNyEwGCmGccu8+M/A5VH6Bv 9IwGBfspHJiScjbWhyzcPgnbpbG5PKWRrM4Zwvqo9gQBszVwjR1LsG3qF8pEXhj5zLWJPV 3Wo5It1HHSQkjeSIIE0TXL1mFRLeeD8SG+GR0iy+Wiux8XiMYvhe1IoZTrScEm5sSiFe/q wFP/z8ehKmjOni/OZTOeqQwJXssJJ+oZPYUQrQDMLZNqUA9dpRSoxw2IS/T0/7wMhuPhrj NqyG1/EK0C+Re0kDDOFwdqs3VKbQ37k4oBwoUtALzFlNIRHpM33CHPBGxtHtRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cTkrj3sYGz10sH for ; Sat, 20 Sep 2025 22:41:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-80f6846bf6dso88266185a.2 for ; Sat, 20 Sep 2025 15:41:57 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU0Kx7rClp9zykliU4lb2UDug3GZBLleHIvdQqrFaMTqgOhk03UYubUGwX4hc4/lCKm5SPDoJXt3zRRnsMlqygFYg+u4Q==@freebsd.org X-Gm-Message-State: AOJu0YyQdaxN9EvY9jNxxk0Ca8f1gnAkSl5ld6hh3gU4AeCrAb5u7Yff BTIs+4yESijEpC6OzKAnkXIry/hr3JGdRV0noyWNgDMi1xTC79fmiu8KNbvDxs21SDsG2qGlzqV ThYkJy3ilBvwJeWmxJ3a5JnSWjPaOxxI= X-Google-Smtp-Source: AGHT+IE6kG3I2I0cE0DIZkQBF8wSg3HZy47QNzdykHx5sYhW8fA7jvQm/JRJXbLr4i9Y3t1LpwnNVZGl+X0Bm+j5Hug= X-Received: by 2002:a05:622a:2b44:b0:4b6:2efe:2f73 with SMTP id d75a77b69052e-4c23cf3bee3mr48901081cf.1.1758408117075; Sat, 20 Sep 2025 15:41:57 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202509191603.58JG3EF6037438@gitrepo.freebsd.org> In-Reply-To: <202509191603.58JG3EF6037438@gitrepo.freebsd.org> From: Nuno Teixeira Date: Sat, 20 Sep 2025 23:41:46 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWBwHZxxEYd1MmE99_rsb6fGtP4YyLkIUBA1KnikhMa_w8d29w55NGGGT4g Message-ID: Subject: Re: git: 87a7b35f04b6 - main - bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid To: Ed Maste Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000003046b1063f434bf4" --0000000000003046b1063f434bf4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello! I've just upgraded to a recent main and on boot i see: `sysctl: unknown oid 'vfs.zfs.min_auto_ashift' at line 9` I remember this line in /etc/sysctl.conf for years: ``` # # This file is read when going to multi-user and its contents piped thru # ``sysctl'' to adjust kernel values. ``man 5 sysctl.conf'' for details. # # Uncomment this to prevent users from seeing information about processes that # are being run under another UID. #security.bsd.see_other_uids=3D0 vfs.zfs.min_auto_ashift=3D12 ``` Do we need to fix it from vfs.zfs.min_auto_ashift -> vfs.zfs.vdev.min_auto_ashift on /etc/sysctl.conf? Cheers, Ed Maste escreveu (sexta, 19/09/2025 =C3=A0(s) 17:03): > The branch main has been updated by emaste: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D87a7b35f04b60956e9aa192680ae807= 73ec38f14 > > commit 87a7b35f04b60956e9aa192680ae80773ec38f14 > Author: Siva Mahadevan > AuthorDate: 2025-07-15 16:45:24 +0000 > Commit: Ed Maste > CommitDate: 2025-09-19 16:02:57 +0000 > > bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid > > Signed-off-by: Siva Mahadevan > PR: 266374 > Pull request: https://github.com/freebsd/freebsd-src/pull/1851 > Reviewed by: emaste > Sponsored by: The FreeBSD Foundation > --- > usr.sbin/bsdinstall/scripts/zfsboot | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/usr.sbin/bsdinstall/scripts/zfsboot > b/usr.sbin/bsdinstall/scripts/zfsboot > index aa05faa7d3dd..5fbf56ea59ac 100755 > --- a/usr.sbin/bsdinstall/scripts/zfsboot > +++ b/usr.sbin/bsdinstall/scripts/zfsboot > @@ -69,7 +69,7 @@ f_include $BSDCFG_SHARE/variable.subr > : ${ZFSBOOT_VDEV_TYPE:=3Dstripe} > > # > -# Should we use sysctl(8) vfs.zfs.min_auto_ashift=3D12 to force 4K secto= rs? > +# Should we use sysctl(8) vfs.zfs.vdev.min_auto_ashift=3D12 to force 4K > sectors? > # > : ${ZFSBOOT_FORCE_4K_SECTORS=3D1} > > @@ -221,7 +221,7 @@ PRINTF_CONF=3D"printf '%s=3D\"%%s\"\\\n' %s >> \"%s\"= " > PRINTF_FSTAB=3D'printf "$FSTAB_FMT" "%s" "%s" "%s" "%s" "%s" "%s" >> "%s= "' > SHELL_TRUNCATE=3D':> "%s"' > SWAP_GMIRROR_LABEL=3D'gmirror label swap %s' > -SYSCTL_ZFS_MIN_ASHIFT_12=3D'sysctl vfs.zfs.min_auto_ashift=3D12' > +SYSCTL_ZFS_MIN_ASHIFT_12=3D'sysctl vfs.zfs.vdev.min_auto_ashift=3D12' > UMOUNT=3D'umount "%s"' > ZFS_CREATE_WITH_OPTIONS=3D'zfs create %s "%s"' > ZFS_MOUNT=3D'zfs mount "%s"' > @@ -255,7 +255,7 @@ msg_encrypt_disks=3D"Encrypt Disks?" > msg_encrypt_disks_help=3D"Use geli(8) to encrypt all data partitions" > msg_error=3D"Error" > msg_force_4k_sectors=3D"Force 4K Sectors?" > -msg_force_4k_sectors_help=3D"Align partitions to 4K sector boundries and > set vfs.zfs.min_auto_ashift=3D12" > +msg_force_4k_sectors_help=3D"Align partitions to 4K sector boundries and > set vfs.zfs.vdev.min_auto_ashift=3D12" > msg_freebsd_installer=3D"$OSNAME Installer" > msg_geli_password=3D"Enter a strong passphrase, used to protect your > encryption keys. You will be required to enter this passphrase each time > the system is booted" > msg_geli_setup=3D"Initializing encryption on selected disks,\n this will > take several seconds per disk" > @@ -1099,7 +1099,7 @@ zfs_create_boot() > # > f_dprintf "$funcname: Preparing disk partitions for ZFS pool..." > > - # Force 4K sectors using vfs.zfs.min_auto_ashift=3D12 > + # Force 4K sectors using vfs.zfs.vdev.min_auto_ashift=3D12 > if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; then > f_dprintf "$funcname: With 4K sectors..." > f_eval_catch $funcname sysctl "$SYSCTL_ZFS_MIN_ASHIFT_12"= \ > @@ -1382,7 +1382,7 @@ zfs_create_boot() > > if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; then > f_eval_catch $funcname echo "$ECHO_APPEND" \ > - 'vfs.zfs.min_auto_ashift=3D12' \ > + 'vfs.zfs.vdev.min_auto_ashift=3D12' \ > $BSDINSTALL_TMPETC/sysctl.conf.zfs || return $FAILUR= E > fi > > > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --0000000000003046b1063f434bf4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello!

I've just upgrade= d to a recent main and on boot i see:

`sysctl: unknown oid 'vfs.= zfs.min_auto_ashift' at line 9`

I remember this line = in /etc/sysctl.conf for years:

```
#
# =C2=A0This file = is read when going to multi-user and its contents piped thru
# =C2=A0``s= ysctl'' to adjust kernel values. =C2=A0``man 5 sysctl.conf''= ; for details.
#

# Uncomment this to prevent users from seeing in= formation about processes that
# are being run under another UID.
#se= curity.bsd.see_other_uids=3D0
vfs.zfs.min_auto_ashift=3D12
```
Do we need to fix it from=C2=A0vfs<= /span>.zfs.min_auto_ashift ->=C2=A0vfs.zfs.vdev.min_auto_ashift on /etc/sysctl.conf?

<= /div>
Cheers,

Ed Maste <emaste@freebsd.org> escreveu (sexta, 19/09/2025= =C3=A0(s) 17:03):
The branch main has been updated by emaste:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3D87a7b35f04b60956e9aa192680ae80773ec38f14
commit 87a7b35f04b60956e9aa192680ae80773ec38f14
Author:=C2=A0 =C2=A0 =C2=A0Siva Mahadevan <me@svmhdvn.name>
AuthorDate: 2025-07-15 16:45:24 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
CommitDate: 2025-09-19 16:02:57 +0000

=C2=A0 =C2=A0 bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid

=C2=A0 =C2=A0 Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
=C2=A0 =C2=A0 PR: 266374
=C2=A0 =C2=A0 Pull request: https://github.com/freeb= sd/freebsd-src/pull/1851
=C2=A0 =C2=A0 Reviewed by: emaste
=C2=A0 =C2=A0 Sponsored by: The FreeBSD Foundation
---
=C2=A0usr.sbin/bsdinstall/scripts/zfsboot | 10 +++++-----
=C2=A01 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/usr.sbin/bsdinstall/scripts/zfsboot b/usr.sbin/bsdinstall/scri= pts/zfsboot
index aa05faa7d3dd..5fbf56ea59ac 100755
--- a/usr.sbin/bsdinstall/scripts/zfsboot
+++ b/usr.sbin/bsdinstall/scripts/zfsboot
@@ -69,7 +69,7 @@ f_include $BSDCFG_SHARE/variable.subr
=C2=A0: ${ZFSBOOT_VDEV_TYPE:=3Dstripe}

=C2=A0#
-# Should we use sysctl(8) vfs.zfs.min_auto_ashift=3D12 to force 4K sectors= ?
+# Should we use sysctl(8) vfs.zfs.vdev.min_auto_ashift=3D12 to force 4K se= ctors?
=C2=A0#
=C2=A0: ${ZFSBOOT_FORCE_4K_SECTORS=3D1}

@@ -221,7 +221,7 @@ PRINTF_CONF=3D"printf '%s=3D\"%%s\"\= \\n' %s >> \"%s\""
=C2=A0PRINTF_FSTAB=3D'printf "$FSTAB_FMT" "%s" &quo= t;%s" "%s" "%s" "%s" "%s" >= > "%s"'
=C2=A0SHELL_TRUNCATE=3D':> "%s"'
=C2=A0SWAP_GMIRROR_LABEL=3D'gmirror label swap %s'
-SYSCTL_ZFS_MIN_ASHIFT_12=3D'sysctl vfs.zfs.min_auto_ashift=3D12' +SYSCTL_ZFS_MIN_ASHIFT_12=3D'sysctl vfs.zfs.vdev.min_auto_ashift=3D12&#= 39;
=C2=A0UMOUNT=3D'umount "%s"'
=C2=A0ZFS_CREATE_WITH_OPTIONS=3D'zfs create %s "%s"'
=C2=A0ZFS_MOUNT=3D'zfs mount "%s"'
@@ -255,7 +255,7 @@ msg_encrypt_disks=3D"Encrypt Disks?"
=C2=A0msg_encrypt_disks_help=3D"Use geli(8) to encrypt all data partit= ions"
=C2=A0msg_error=3D"Error"
=C2=A0msg_force_4k_sectors=3D"Force 4K Sectors?"
-msg_force_4k_sectors_help=3D"Align partitions to 4K sector boundries = and set vfs.zfs.min_auto_ashift=3D12"
+msg_force_4k_sectors_help=3D"Align partitions to 4K sector boundries = and set vfs.zfs.vdev.min_auto_ashift=3D12"
=C2=A0msg_freebsd_installer=3D"$OSNAME Installer"
=C2=A0msg_geli_password=3D"Enter a strong passphrase, used to protect = your encryption keys. You will be required to enter this passphrase each ti= me the system is booted"
=C2=A0msg_geli_setup=3D"Initializing encryption on selected disks,\n t= his will take several seconds per disk"
@@ -1099,7 +1099,7 @@ zfs_create_boot()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 #
=C2=A0 =C2=A0 =C2=A0 =C2=A0 f_dprintf "$funcname: Preparing disk parti= tions for ZFS pool..."

-=C2=A0 =C2=A0 =C2=A0 =C2=A0# Force 4K sectors using vfs.zfs.min_auto_ashif= t=3D12
+=C2=A0 =C2=A0 =C2=A0 =C2=A0# Force 4K sectors using vfs.zfs.vdev.min_auto_= ashift=3D12
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; t= hen
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f_dprintf "$fu= ncname: With 4K sectors..."
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f_eval_catch $funcn= ame sysctl "$SYSCTL_ZFS_MIN_ASHIFT_12" \
@@ -1382,7 +1382,7 @@ zfs_create_boot()

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if [ "$ZFSBOOT_FORCE_4K_SECTORS" ]; t= hen
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f_eval_catch $funcn= ame echo "$ECHO_APPEND" \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '= ;vfs.zfs.min_auto_ashift=3D12' \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '= ;vfs.zfs.vdev.min_auto_ashift=3D12' \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0$BSDINSTALL_TMPETC/sysctl.conf.zfs || return $FAILURE
=C2=A0 =C2=A0 =C2=A0 =C2=A0 fi




--
Nuno Teixeira
=
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--0000000000003046b1063f434bf4--