From nobody Sat May 30 21:50:17 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gSYmp6D9Gz6gjTp for ; Sat, 30 May 2026 21:50:18 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gSYmp5V2fz3PVr for ; Sat, 30 May 2026 21:50:18 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780177818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=40ZmJJwjffpTZkUNCztvwIr0VirfUPVGRdgoN0oTeW4=; b=IMLt7d5vILM/JtPC69JcScWYqKpb1fMubT/qa6rCUWI7zaKKlZnziJKYNy4Xr+5Zm46LW6 fPD2ubqLm+yIfHQmI8hiZsl5c4brUGUVUNG6RfsRX19XgNRVqY6vAsNpcwD1DvPyQ+Doa7 ilGQ8spm7HtkMqnSdhbJk80Qb8ag1whbQj5wAWohks6mf5uiICtLn0p0SIiei1gRMQf/vP 3wxJmyZ3AHc6dy24e6CFSxWlI0qwRxVKlhrwXA4K0sRYbumkzyBPxYDjpo+8Mq1JDHL1NN kXdCdo2VVYujeqocIqsENx9qiUttMcbc8DJxV2II1n/u9BdjFCvtG3+pTa4wdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780177818; a=rsa-sha256; cv=none; b=w95EACslhtfFZOAOU0jZuefDBqivRK5Yw1CuKEyF21Q6YlRaJh3kpWN3XXUhGueMCetFA5 9/Rc4uK3WnGSitbR758grek5eoXytLkdoo56MRLEtW/hD7tJD7YfvpIMYnSHd0j/QcwFNq 3m/mieFhJp97Ds9fDfatMBZRHTAQfLmaWlQaWFTh+svnyOOstWcrBDR6C5RF2opEd/eXli SLNiKlT/Zh5zwyR1N72XQlfAR1fUhmfiN+A6eHKUmSMMdrxkgpdgMMbbaVuX/EPI/FRLLQ Ina6dyffdv5zJPEQcI7wmrbP46xQO/b7tCyNMoDFKjswvoYcXUfJ00WAVhLHpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780177818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=40ZmJJwjffpTZkUNCztvwIr0VirfUPVGRdgoN0oTeW4=; b=WZHpTB2Tj6w/hOADJ/+wQtZ3Q2cAwxp7TzUUCgu53qOz7N7O4mys8eQv+sZyHdnrQnawS4 AbRdl3J2QfmkU6dWTrdWPggwoQ8JxorOopfd+gQOYvVdk+Tcoczm0akHbyD1TOuy2T0lgb SaMpthfor24SpMHDhH1gnrsuYn4Dyrqb8z6P45XTA/nJv80CIlQpLJrRpHiswdfEJ6nBtS fwhdCog3JAtYPqDO8iySdFlB5wn/4SimMN5Je5IYnCW/wqhHguPquQPQjnTYfTXvwQkmY1 +7Q4t+MEiMFhosLSJ+zqSnGsXyzEn9av9LFX57e84Ae8SwHzVkPotYTeq4yNbA== Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: vexeduxr) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gSYmp4r21zDrb for ; Sat, 30 May 2026 21:50:18 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-36d8b644473so237274a91.3 for ; Sat, 30 May 2026 14:50:18 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ842/Zmx2NExByLmKhU5nURGDFdVrREPkVeyQqXm6QK4xPqunlfdTO7EVXMsa53EsTXBzS8Ox5lLrwShQqKTc94+rMadw==@freebsd.org X-Gm-Message-State: AOJu0Yy3NyX+zqUg+T0amjAVTMCIAlqdIFe9940Qo7TpUT5SNWHa0hOV 8YqsAK3la69bcv7somKI6FLxfHlHdupjNleS5zMxkLojmmRWV1tWILzDtW3PhnRpzkubxVzBswG EM2/YbldXpcRTg/QY1JZRW7db7E7nXqk= X-Received: by 2002:a17:90b:17ce:b0:366:52fe:e749 with SMTP id 98e67ed59e1d1-36c4ff0b9c0mr4276144a91.5.1780177817616; Sat, 30 May 2026 14:50:17 -0700 (PDT) Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 May 2026 14:50:17 -0700 Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 May 2026 14:50:17 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 From: Ahmad Khalifa X-Mailer: aerc 0.21.0 References: <6a1a4f38.32b9d.5eb5f95e@gitrepo.freebsd.org> <20260530190827.15ba6ffa@thor.sb211.local> In-Reply-To: <20260530190827.15ba6ffa@thor.sb211.local> Date: Sat, 30 May 2026 14:50:17 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4K7QjBGPXdMyYyUwBVy8-RgYCctfNzlQYm9f_VIURYX6wZTn0jWYUgKcxc Message-ID: Subject: Re: git: 2fa4bdd7f9e9 - main - edk2: enable static asserts for *INT64 alignment To: A FreeBSD User Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" On Sat May 30, 2026 at 8:09 PM +0300, A FreeBSD User wrote: > Am Tage des Herren Sat, 30 May 2026 02:45:12 +0000 > Ahmad Khalifa schrieb: > >> The branch main has been updated by vexeduxr: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=2fa4bdd7f9e99698a6652db405c3165fdcd41c1d >> >> commit 2fa4bdd7f9e99698a6652db405c3165fdcd41c1d >> Author: Ahmad Khalifa >> AuthorDate: 2026-05-30 02:40:58 +0000 >> Commit: Ahmad Khalifa >> CommitDate: 2026-05-30 02:40:58 +0000 >> >> edk2: enable static asserts for *INT64 alignment >> >> The ia32 loader is now built with -malign-double, so these should pass. >> >> Differential Revision: https://reviews.freebsd.org/D55386 >> --- >> sys/contrib/edk2/Include/Base.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/sys/contrib/edk2/Include/Base.h b/sys/contrib/edk2/Include/Base.h >> index 3ae798db8429..d3342c9a6ca2 100644 >> --- a/sys/contrib/edk2/Include/Base.h >> +++ b/sys/contrib/edk2/Include/Base.h >> @@ -841,10 +841,8 @@ STATIC_ASSERT (ALIGNOF (INT16) == sizeof (INT16), "Alignment of INT16 >> does not STATIC_ASSERT (ALIGNOF (UINT16) == sizeof (UINT16), "Alignment of UINT16 does not >> meet UEFI Specification Data Type requirements"); STATIC_ASSERT (ALIGNOF (INT32) == sizeof >> (INT32), "Alignment of INT32 does not meet UEFI Specification Data Type requirements"); >> STATIC_ASSERT (ALIGNOF (UINT32) == sizeof (UINT32), "Alignment of UINT32 does not meet UEFI >> Specification Data Type requirements"); -#ifndef _STANDALONE STATIC_ASSERT (ALIGNOF (INT64) >> == sizeof (INT64), "Alignment of INT64 does not meet UEFI Specification Data Type >> requirements"); STATIC_ASSERT (ALIGNOF (UINT64) == sizeof (UINT64), "Alignment of UINT64 >> does not meet UEFI Specification Data Type requirements"); -#endif STATIC_ASSERT (ALIGNOF >> (CHAR8) == sizeof (CHAR8), "Alignment of CHAR8 does not meet UEFI Specification Data Type >> requirements"); STATIC_ASSERT (ALIGNOF (CHAR16) == sizeof (CHAR16), "Alignment of CHAR16 >> does not meet UEFI Specification Data Type requirements"); STATIC_ASSERT (ALIGNOF (INTN) >> == sizeof (INTN), "Alignment of INTN does not meet UEFI Specification Data Type >> requirements"); >> > > The commit seems to disturb building process and gets rogue with: > [...] > In file included from /usr/src/sys/contrib/edk2/Include/Uefi/UefiBaseType.h:16: > /usr/src/sys/contrib/edk2/Include/Base.h:844:16: error: static assertion failed due to > requirement '_Alignof(long long) == sizeof(long long)': Alignment of INT64 does not meet UEFI > Specification Data Type requirements 844 | STATIC_ASSERT (ALIGNOF (INT64) == sizeof (INT64), > "Alignment of INT64 does not meet UEFI Specification Data Type requirements"); | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sys/contrib/edk2/Include/Base.h:778:24: note: > expanded from macro 'ALIGNOF' I can't reproduce with the defaults, do you have any loader related build options changed? Also, can you tell which target this failed on? Thanks. > > > Regards > oh