From owner-svn-src-head@FreeBSD.ORG Sat Nov 8 16:11:54 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 39A0070F; Sat, 8 Nov 2014 16:11:54 +0000 (UTC) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E2CF7F23; Sat, 8 Nov 2014 16:11:53 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id DC7A525D3A92; Sat, 8 Nov 2014 16:11:50 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id EB9A4C7700C; Sat, 8 Nov 2014 16:11:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id nsaKhtHErDAW; Sat, 8 Nov 2014 16:11:48 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4420:cabc:c8ff:fe8b:4fe6] (orange-tun0-ula.sbone.de [IPv6:fde9:577b:c1a9:4420:cabc:c8ff:fe8b:4fe6]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 4E073C76FF5; Sat, 8 Nov 2014 16:11:46 +0000 (UTC) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r274274 - head/sys/net From: "Bjoern A. Zeeb" In-Reply-To: <20141108160304.GQ1031@FreeBSD.org> Date: Sat, 8 Nov 2014 16:11:44 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <17FD4DFD-D5A0-45DC-B7AC-CD44EF49B33E@FreeBSD.org> References: <201411080723.sA87N2hx046823@svn.freebsd.org> <8B3F77C9-C79D-4303-ADB6-310B3928D51C@FreeBSD.org> <20141108160304.GQ1031@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Nov 2014 16:11:54 -0000 On 08 Nov 2014, at 16:03 , Gleb Smirnoff wrote: > On Sat, Nov 08, 2014 at 03:06:20PM +0000, Bjoern A. Zeeb wrote: > B> > Modified: head/sys/net/if.c > B> > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > B> > --- head/sys/net/if.c Sat Nov 8 06:43:33 2014 = (r274273) > B> > +++ head/sys/net/if.c Sat Nov 8 07:23:01 2014 = (r274274) > B> > @@ -265,13 +265,12 @@ ifnet_byindex_ref(u_short idx) > B> > * Allocate an ifindex array entry; return 0 on success or an = error on > B> > * failure. > B> > */ > B> > -static int > B> > -ifindex_alloc_locked(u_short *idxp) > B> > +static u_short > B>=20 > B> That feels like going backwards; we should really make sure we = can support ifindexes >> 64k >=20 > This isn't backwards, since if_index was u_short before the commit. >=20 > I will take into account your wish and see if we can enlarge if_index. Yeah, I think we fixed most of the APIs to be able to extend it and = brooks had a spare a while ago I think. Last time this was discussed the leaning was to go straight to uint64_t = to avoid any problems for the next two decades ;-) /bz =97=20 Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983