From owner-svn-ports-all@freebsd.org Wed May 9 15:29:32 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B19EFC0FF3; Wed, 9 May 2018 15:29:32 +0000 (UTC) (envelope-from ultima1252@gmail.com) Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7B3D17F37E; Wed, 9 May 2018 15:29:31 +0000 (UTC) (envelope-from ultima1252@gmail.com) Received: by mail-lf0-f49.google.com with SMTP id p85-v6so16162503lfg.7; Wed, 09 May 2018 08:29:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WhiI52wRxlo6VVPXPxAobtnP9TrmtHFfT9vFcCqEAPI=; b=fGy/iSlzosUpgspgkzrVS3PWx4xx/1YC08iqSxczDZmFFnkVmQZDjg88bPWZX9E4Je uSnf7hhj0CEEfdzoS9Cz/oURhV+pi8UJGJ7bbdHHQ8Ec63FdXiJJMU0nAAb0Uonb+xUW cbFFOnARmN6VOeI+qgBI0rkc9+TLN4REvaHB+2R+HSaTJIw924vMUWfCHPiJuSLxrl2j VOLijrYbemq+rL7a0U8u6TSnPBMjbtKruZT8G2KQpJ01oKEEaXuj5ABMJSYuFX+QPksy enBJJWLXv3i8xj6gBqJdhbDEmbMWbYpqXNQ+5jvtp9zW8Z8Ns3IGlV2UPYs/G0GnRWww mDrA== X-Gm-Message-State: ALKqPwfshakvaYpEIOpovsgBDeLezPqQfllwRgGNyr0maAS4uCidr0fL btsQVcNvQAN9jSNFSkeVtfJYo8We X-Google-Smtp-Source: AB8JxZpuIbLKJ6kubtxfl7psNOODxdqxEwU4hiDFPthQJEdqXpzzzCW4S7DzKA7t6pSf1ckBKx7Usg== X-Received: by 2002:a19:1444:: with SMTP id k65-v6mr8809401lfi.80.1525879763510; Wed, 09 May 2018 08:29:23 -0700 (PDT) Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com. [209.85.215.54]) by smtp.gmail.com with ESMTPSA id l136-v6sm5825136lfb.45.2018.05.09.08.29.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 08:29:23 -0700 (PDT) Received: by mail-lf0-f54.google.com with SMTP id y72-v6so37797719lfd.2; Wed, 09 May 2018 08:29:23 -0700 (PDT) X-Received: by 2002:a19:164f:: with SMTP id m76-v6mr30809839lfi.27.1525879763028; Wed, 09 May 2018 08:29:23 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:c788:0:0:0:0:0 with HTTP; Wed, 9 May 2018 08:29:22 -0700 (PDT) In-Reply-To: References: <201805060046.w460kACv084700@repo.freebsd.org> From: Ultima Date: Wed, 9 May 2018 08:29:22 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r469172 - head/net/guacamole-server To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 15:29:32 -0000 Hey Jan, Thanks for the patch. I have been struggling to get adequate time to find the proper flag to fix the depreciation build failures. Can you please go ahead and commit it? You have my blessing. =D Best regards, Richard Gallamore On Wed, May 9, 2018 at 12:49 AM, Jan Beich wrote: > Richard Gallamore writes: > > > Author: ultima > > Date: Sun May 6 00:46:09 2018 > > New Revision: 469172 > > URL: https://svnweb.freebsd.org/changeset/ports/469172 > > > > Log: > > * Remove GUACENC from defaults > > > > Guacamole-server is not compatible with Ffmpeg > > version 4.0+. Will readd once fixed upstream. > > Does the following patch help? See build log: https://ptpb.pw/6js3 > > In general, allowing ports to use -Werror is a bad idea as it tends to > bring misery during compiler or dependency upgrades. It should probably > be stripped like -O3 -funroll-loops are. However, more specific warnings > like -Werror=implicit-function-declaration -Werror=return-type are fine. > > Besides, FreeBSD wasn't the first to update to FFmpeg 4.0. Arch Linux > will join the fray soon. > https://repology.org/metapackage/ffmpeg/history > https://www.archlinux.org/todo/ffmpeg-40/ > > diff --git net/guacamole-server/Makefile net/guacamole-server/Makefile > index 51148ef23a4c..978e85da0942 100644 > --- net/guacamole-server/Makefile > +++ net/guacamole-server/Makefile > @@ -3,7 +3,7 @@ > > PORTNAME= guacamole-server > DISTVERSION= 0.9.14 > -PORTREVISION= 2 > +PORTREVISION= 3 > CATEGORIES= net > > MAINTAINER= ultima@FreeBSD.org > @@ -39,7 +39,7 @@ SUB_LIST= GUACD_USER=${USERS} \ > GUACD_GROUP=${GROUPS} > > OPTIONS_DEFINE= GUACENC NLS SSL WEBP > -OPTIONS_DEFAULT= RDP SSH SSL VNC VORBIS PULSEAUDIO WEBP > +OPTIONS_DEFAULT= GUACENC PULSEAUDIO RDP SSH SSL VNC VORBIS WEBP > OPTIONS_GROUP= SP AUDIO > OPTIONS_GROUP_SP= RDP SSH VNC > OPTIONS_GROUP_AUDIO= VORBIS PULSEAUDIO > @@ -51,10 +51,10 @@ RDP_DESC= RDP protocol support > SP_DESC= Supported Protocols > VNC_DESC= VNC protocol support > > -GUACENC_BROKEN= fails to build with ffmpeg 4.0 > GUACENC_CONFIGURE_ENABLE= guacenc > GUACENC_CONFIGURE_WITH= libavcodec libavutil libswscale > GUACENC_LIB_DEPENDS= libavcodec.so:multimedia/ffmpeg > +GUACENC_CFLAGS= -Wno-error=deprecated # > avcodec_register_all > NLS_USES= gettext-runtime > PULSEAUDIO_CONFIGURE_WITH= pulse > PULSEAUDIO_LIB_DEPENDS= libpulse.so:audio/pulseaudio >