Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Oct 2012 16:02:03 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Jan Beich <jbeich@tormail.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@FreeBSD.org>
Subject:   Re: svn commit: r242120 - head/usr.sbin/cpucontrol
Message-ID:  <508A97DB.3080105@FreeBSD.org>
In-Reply-To: <1TRk6h-000L25-0p@internal.tormail.org>
References:  <201210260250.q9Q2oH8P005136__18925.7027851001$1351219846$gmane$org@svn.freebsd.org> <1TRk6h-000L25-0p@internal.tormail.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-10-26 15:37, Jan Beich wrote:
> Eitan Adler <eadler@FreeBSD.org> writes:
>
>> Author: eadler
>> Date: Fri Oct 26 02:50:16 2012
>> New Revision: 242120
>> URL: http://svn.freebsd.org/changeset/base/242120
>>
>> Log:
>>    This utility builds without NO_WCAST_ALIGN
>
> Not for clang. It probably predates NO_WCAST_ALIGN.clang= support.
>
> intel.c:66:3: warning: cast from 'char *' to 'uint32_t *' (aka 'unsigned int *')
>        increases required alignment from 1 to 4 [-Wcast-align]
>          ((uint32_t *)vendor)[0] = idargs.data[1];
>           ^~~~~~~~~~~~~~~~~~

Yes, on x86, you can safely turn off the -Wcast-align warnings, if it is
easier.  It is probably not worth the trouble to go through the code and
fix the alignment issues, if it will never be run on alignment-sensitive
architectures.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?508A97DB.3080105>