From owner-svn-src-head@FreeBSD.ORG  Fri Oct 26 14:02:03 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id ED1F7391;
 Fri, 26 Oct 2012 14:02:03 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
 [IPv6:2001:7b8:2ff:146::2])
 by mx1.freebsd.org (Postfix) with ESMTP id A6BA18FC0C;
 Fri, 26 Oct 2012 14:02:03 +0000 (UTC)
Received: from [192.168.0.6] (spaceball.home.andric.com [192.168.0.6])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 60C685C59;
 Fri, 26 Oct 2012 16:02:02 +0200 (CEST)
Message-ID: <508A97DB.3080105@FreeBSD.org>
Date: Fri, 26 Oct 2012 16:02:03 +0200
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Jan Beich <jbeich@tormail.org>
Subject: Re: svn commit: r242120 - head/usr.sbin/cpucontrol
References: <201210260250.q9Q2oH8P005136__18925.7027851001$1351219846$gmane$org@svn.freebsd.org>
 <1TRk6h-000L25-0p@internal.tormail.org>
In-Reply-To: <1TRk6h-000L25-0p@internal.tormail.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Eitan Adler <eadler@FreeBSD.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2012 14:02:04 -0000

On 2012-10-26 15:37, Jan Beich wrote:
> Eitan Adler <eadler@FreeBSD.org> writes:
>
>> Author: eadler
>> Date: Fri Oct 26 02:50:16 2012
>> New Revision: 242120
>> URL: http://svn.freebsd.org/changeset/base/242120
>>
>> Log:
>>    This utility builds without NO_WCAST_ALIGN
>
> Not for clang. It probably predates NO_WCAST_ALIGN.clang= support.
>
> intel.c:66:3: warning: cast from 'char *' to 'uint32_t *' (aka 'unsigned int *')
>        increases required alignment from 1 to 4 [-Wcast-align]
>          ((uint32_t *)vendor)[0] = idargs.data[1];
>           ^~~~~~~~~~~~~~~~~~

Yes, on x86, you can safely turn off the -Wcast-align warnings, if it is
easier.  It is probably not worth the trouble to go through the code and
fix the alignment issues, if it will never be run on alignment-sensitive
architectures.