From owner-svn-src-all@freebsd.org Sun Nov 24 17:24:26 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B532B1B4EB7; Sun, 24 Nov 2019 17:24:26 +0000 (UTC) (envelope-from freebsd@bdragon.rtk0.net) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47LcV13vh6z4F9c; Sun, 24 Nov 2019 17:24:25 +0000 (UTC) (envelope-from freebsd@bdragon.rtk0.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B27D922687; Sun, 24 Nov 2019 12:24:24 -0500 (EST) Received: from imap1 ([10.202.2.51]) by compute5.internal (MEProxy); Sun, 24 Nov 2019 12:24:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=xV3C3u QwcU2VHQgvYkm1H+fkVRYo6qJ5TEViyjeVGYc=; b=rrbXkVkyrJV1b8gZrutzcB RVLEnyZCDNV47CeZ6FHxscw8AT4ZHDdACDIwrzsb0inP0LnmI7Ed6s1FQEfwNVHh YRdhn/urgp9yGgUOcMZb2xviSNQcQB0CZkBQSIgEcjCzzDgV3UW0DmYpCGRxYGtw TcFqRWaQTLisJumwCS2OExqNwRguYMYjimGY9HdXzju2ZLI2Al5ATGEgIzg5wKMw T76V0EjGFXZfMVofaGo6Q2VQmbFxPFWEpr9Z/r6vZ8P2hdtnKzjubL7ZuQFP5Euy +yrqdlXmZrr8aOXLMeY347KCSH0vhMElG4e9dZHTTT+umlKSY+mZB712dESobDtA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehkedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfuehr rghnughonhcuuegvrhhgrhgvnhdfuceofhhrvggvsghsugessggurhgrghhonhdrrhhtkh dtrdhnvghtqeenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucfrrghrrghmpehm rghilhhfrhhomhepfhhrvggvsghsugessggurhgrghhonhdrrhhtkhdtrdhnvghtnecuve hluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 3DFF5C200A4; Sun, 24 Nov 2019 12:24:24 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-578-g826f590-fmstable-20191119v1 Mime-Version: 1.0 Message-Id: In-Reply-To: <20191124164714.GD2707@kib.kiev.ua> References: <201911240435.xAO4ZTgw070233@repo.freebsd.org> <20191124130441.GA2707@kib.kiev.ua> <849a4306-1cf7-4296-b594-236caa1572a0@www.fastmail.com> <20191124164714.GD2707@kib.kiev.ua> Date: Sun, 24 Nov 2019 11:24:04 -0600 From: "Brandon Bergren" To: "Konstantin Belousov" Cc: "Justin Hibbits" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355045 - head/libexec/rtld-elf/powerpc Content-Type: text/plain X-Rspamd-Queue-Id: 47LcV13vh6z4F9c X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=rrbXkVky; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@bdragon.rtk0.net has no SPF policy when checking 66.111.4.29) smtp.mailfrom=freebsd@bdragon.rtk0.net X-Spamd-Result: default: False [-4.88 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[messagingengine.com:s=fm1]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; IP_SCORE(-3.49)[ip: (-9.83), ipnet: 66.111.4.0/24(-4.87), asn: 11403(-2.68), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[rtk0.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[messagingengine.com:+]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_LOW(-0.10)[29.4.111.66.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; MID_RHS_WWW(0.50)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Nov 2019 17:24:26 -0000 On Sun, Nov 24, 2019, at 10:47 AM, Konstantin Belousov wrote: > On Sun, Nov 24, 2019 at 10:32:23AM -0600, Brandon Bergren wrote: > > On Sun, Nov 24, 2019, at 7:04 AM, Konstantin Belousov wrote: > > > On Sun, Nov 24, 2019 at 04:35:29AM +0000, Justin Hibbits wrote: > > > > Author: jhibbits > > > > Date: Sun Nov 24 04:35:29 2019 > > > > New Revision: 355045 > > > > URL: https://svnweb.freebsd.org/changeset/base/355045 > > > > > > > > Log: > > > > rtld/powerpc: Fix _rtld_bind_start for powerpcspe > > > > > > > > Summary: > > > > We need to save off the full 64-bit register, not just the low 32 bits, > > > > of all registers getting saved off in _rtld_bind_start. Additionally, > > > > we need to save off the other SPE registers (SPEFSCR and accumulator), > > > > so that their program state is not affected by the PLT resolver. > > > Why do you need to save these registers ? Why would rtld touch them ? > > > > > Out of a need to make the binder as invisible as possible when interacting with code that may or may not be following the normal ABI rules regarding who is responsible for saving stuff. > > > > It's not just C code using it. > This was not the question. If a register is saved at the bind entry, it > means that it is used by rtld itself. I am surprised that rtld needs > anything from SPE. You have a point there. It's possible it's just the r0 damage (from using it to touch the 64-bit SPRs) combined with the alignment problem was throwing off the testing, and we don't actually have to save the high word of everything and that the negative results during all the testing was all from having either the r0 issue OR the alignment issue when doing the test.