From owner-freebsd-current@freebsd.org Tue Dec 19 10:02:03 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6B012E9C0FB for ; Tue, 19 Dec 2017 10:02:03 +0000 (UTC) (envelope-from 010001606e350447-ea112c5b-2179-4828-9899-f33e704aa131-000000@amazonses.com) Received: from a8-13.smtp-out.amazonses.com (a8-13.smtp-out.amazonses.com [54.240.8.13]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2FD5570F4D for ; Tue, 19 Dec 2017 10:02:02 +0000 (UTC) (envelope-from 010001606e350447-ea112c5b-2179-4828-9899-f33e704aa131-000000@amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ae7m2yrxjw65l2cqdpjxuucyrvy564tn; d=tarsnap.com; t=1513677456; h=Subject:To:References:Cc:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=sbi2dnClvEChZUK0VBs88LfsjSmWXEeCAklqMLbtHAQ=; b=rV5MP00JCvlJuAZrW4ZVNG0D02eXwFLISwpdVHcKmOc/7FhZcKqnxc0OdbVosqwg z0LrYbhypVb/nEIPUPD8nLbPUJvBbbGSSPDQLSSS7VygJqmCJHQc/aqH2VbWtvRoenh rK3pik8qHXoZ1KY6s/ioL6hdfh764AoElKM+krJM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1513677456; h=Subject:To:References:Cc:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=sbi2dnClvEChZUK0VBs88LfsjSmWXEeCAklqMLbtHAQ=; b=aQNwly1Cqdz8gd7S3iDPGYxNWEqJPol3zD22r18nZSOkgVLslOW8WZhFHCKUMYo0 moXon0xwvadWWj7eCyYKFtDmBWJS5tK5eKP+/LFHo9ILBNq8qkf1Kec1uIYR4DiCuis 5QBUsb6+x8V50hPUS8Z1mXcXUoP+kvkcLDmOsb40= Subject: Re: RFC: Removing hpt* drivers from GENERIC To: "O'Connor, Daniel" References: <0100015f557d9cd2-098d2e99-d4c4-45ce-90bf-47b76455a6de-000000@email.amazonses.com> Cc: "freebsd-current@freebsd.org" , Andrew Turner , Baptiste Daroussin From: Colin Percival Message-ID: <010001606e350447-ea112c5b-2179-4828-9899-f33e704aa131-000000@email.amazonses.com> Date: Tue, 19 Dec 2017 09:57:36 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SES-Outgoing: 2017.12.19-54.240.8.13 Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-Mailman-Approved-At: Tue, 19 Dec 2017 12:09:15 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 10:02:03 -0000 On 10/25/17 15:56, O'Connor, Daniel wrote: >> On 26 Oct 2017, at 08:13, Colin Percival wrote: >> [Proposal for removing hpt* drivers since hpt27xx and hptnr take a long >> time to in DEVICE_PROBE.] > > Seems sensible to me, but also worth contacting the blob authors if > possible and asking them what gives (and if they can fix it). Turns out that they were indeed able to fix it, with startling rapidity. delphij@ committed r325683 (MFCed as r32600[56]) which reduces the time spent in these DEVICE_PROBE routines from ~150 ms down to ~37 *us* on my laptop. So my immediate desire for faster booting has been satisfied with regard to these drivers. I know some people (CCed) were enthusiastic about removing these from GENERIC on the basis that we shouldn't have binary blobs in GENERIC; while I'm certainly sympathetic to this, I'd suggest that it should be done by someone who has time to look at the other binary blobs in the tree and formulate a general policy rather than just picking on the hpt* drivers. Unfortunately, that person is not me; I have 12 days left to submit a talk to AsiaBSDCon about my work on profiling the kernel boot (which is how I noticed the slow probing originally) and then a long list of other places to speed up the boot performance. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid