From owner-svn-src-all@freebsd.org  Sat Oct 29 19:16:27 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89481C262C2;
 Sat, 29 Oct 2016 19:16:27 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net
 [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f])
 by mx1.freebsd.org (Postfix) with ESMTP id 73AA6B75;
 Sat, 29 Oct 2016 19:16:24 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from ford.home.vangyzen.net (unknown [76.164.15.242])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id 297F15648E;
 Sat, 29 Oct 2016 14:16:23 -0500 (CDT)
Subject: Re: svn commit: r306577 - head/sys/netinet
To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org,
 David Bright <dab@FreeBSD.org>
References: <201610020142.u921gjsJ016528@repo.freebsd.org>
 <661a719c-39c8-7a3b-e300-9184475ac2c7@selasky.org>
From: Eric van Gyzen <vangyzen@FreeBSD.org>
Message-ID: <0952149f-97f0-23e9-e39c-28eef3ddeb00@FreeBSD.org>
Date: Sat, 29 Oct 2016 14:16:20 -0500
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <661a719c-39c8-7a3b-e300-9184475ac2c7@selasky.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Oct 2016 19:16:27 -0000

On 10/29/2016 11:50, Hans Petter Selasky wrote:
> On 10/02/16 03:42, Eric van Gyzen wrote:
>> +    if (callout_reset(&ia->ia_garp_timer, (1 << ia->ia_garp_count) * hz,
>> +        garp_rexmit, ia) == 0) {
>> +        ifa_ref(ifa);
>> +    }
> 
> Hi,
> 
> Be careful when you MFC this, because the return values of callout_reset() and
> callout_stop() are not the same in FreeBSD-9, -10 and 11/12.

Thanks for your keen eye, Hans.  Indeed, the submitter (David Bright) discovered
this The Hard Way when porting this forward from 10 to head.  Luckily, though,
that means we already have a version of this patch for 10.

Thanks again,

Eric (and David)