From owner-freebsd-ports@FreeBSD.ORG  Mon May 28 10:37:27 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5F645106567B
	for <ports@freebsd.org>; Mon, 28 May 2012 10:37:27 +0000 (UTC)
	(envelope-from ale@FreeBSD.org)
Received: from andxor.it (relay.andxor.it [195.223.2.3])
	by mx1.freebsd.org (Postfix) with SMTP id 8D3A78FC17
	for <ports@freebsd.org>; Mon, 28 May 2012 10:37:25 +0000 (UTC)
Received: (qmail 69581 invoked from network); 28 May 2012 10:37:17 -0000
Received: from unknown (HELO alex.andxor.it) (192.168.2.30)
	by andxor.it with SMTP; 28 May 2012 10:37:17 -0000
Message-ID: <4FC3555D.9080802@FreeBSD.org>
Date: Mon, 28 May 2012 12:37:17 +0200
From: Alex Dupre <ale@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:12.0) Gecko/20120511 Firefox/12.0 SeaMonkey/2.9.1
MIME-Version: 1.0
To: Jason Helfman <jgh@FreeBSD.org>
References: <20120521220449.GD8317@dormouse.experts-exchange.com>
In-Reply-To: <20120521220449.GD8317@dormouse.experts-exchange.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Mon, 28 May 2012 12:47:12 +0000
Cc: nsand@sura.ru, jon@witchspace.com, kuriyama@FreeBSD.org, bobf@mrp3.com,
	emulation@FreeBSD.org, bkoenig@alpha-tierchen.de,
	hrs@FreeBSD.org, ports@freebsd.org, gelraen.ua@gmail.com,
	delphij@FreeBSD.org, rene@FreeBSD.org, admin@lissyara.su,
	vbox@FreeBSD.org, mirror176@cox.net, jkim@FreeBSD.org, mm@FreeBSD.org
Subject: Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is
 defined before referenced
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 May 2012 10:37:27 -0000

Jason Helfman ha scritto:
> I am working on the following pr, and would like to get others approval to
> the following patch:
> http://people.freebsd.org/~jgh/files/pre-patch.txt
> 
> This patch is fixing several use cases of SRC_BASE before it is defined.

I don't agree for the quantis-kmod patch. I think simply removing
SRC_BASE?= line is the correct fix.

-- 
Alex Dupre