From nobody Mon Mar 23 17:02:38 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fffcj1PZcz6WG5n for ; Mon, 23 Mar 2026 17:03:01 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fffcg6cLXz4MZj for ; Mon, 23 Mar 2026 17:02:54 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-482f454be5bso50599405e9.0 for ; Mon, 23 Mar 2026 10:02:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774285373; x=1774890173; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+9TnMtzWzPLOO8k7SOsmRcxCquB2ro+Nl/DRva+OVuQ=; b=d1MV7mds2B4/dMlx0jtUqiErT98LeY7IIdTTviMWiKSqiwz+MS46O9GZg9m/QGQX2F J+KC8ll5NGMQk/75UwnSuG+e0GRNfIIzDWd9fbNuLTOl3yG5kpcnum/ujcgSGDrtkgZP raX2rVzDZMAQ155kgDvrie6TUN2h+xjpIzrmSjOXyEzPEp7FaBXQ3oYYQqiWXEWintr6 /KJXTruSufFPA4BL1aY5akAFrq1bo+Tvo9bTcY7inRenqfFVoJoLIMnF4Pic19X1hi4c 6kV5DGTZoOt/QZxrnRaoc8GafXTXQ74T0hTFFLWX9SXm0zd2A7CEnBCa4rPY1TXpzYA7 8TdQ== X-Forwarded-Encrypted: i=1; AJvYcCVRnM3uVbRvH1KAt1F+/PAb+gFcyVrZ5vRmeyVK1Wt+naP53fwYGymE4JcjwqfWFaa8TGM92npEPDYfltvGym+qTTPgYw==@freebsd.org X-Gm-Message-State: AOJu0YzHmYbCw2AQBFo5Ni7EYHMRuZtJLRXRN8jToSGmlyUAEeqPc3uB abAe11GljeDumZyeqKS1znbWnwl5o3lbTp6H5AMXz121+6TUzR02Tz+3hHXHb9n3lgbzEaDSZ6u 5fLTm X-Gm-Gg: ATEYQzyKWGXPMd/FZDEb1ddeMDee0ZtGjZyZ1xcihPOsTljwJiEZDq1p4bp+9TvJVRh WQhZGN3VAHZc0yyQ4AoWGd2wKMtQZ0CCRTlJ80DbgsV1hhNFmO4h8RKrnd/CTl290tDPoVYFdig bBzGVMMlohPLbBJnQiYt5eC02cufEgB6oZFTN7xsz821nwYO+33drt4lN4iiMtdlnMJFBqoZEgp CUU0UnaKsDbtfRogK4NcUKCRI7KEUUQT8lg7o+j1njVdj/c28KXbtq+8gqv+IssZEW0Mo2vXEhq /YDar/NbQ/hRLTauSurzTpNHTySjPAIOCjFEW33xe6IXxA8rLgcKr2yP2gCjSdx6cI1/WPrC46s zXVIxnL8Cs2w72XiLm5Jr2bisPf4B7d1vVKjm6VSNPrDSH06WS6yxRTMKnsPmGd2RMnCHYn5T9v vm3wvw8VBxblMxWat22SupwlRdhSXrXKfWfviHozMV7BMPnDd5mPKAH7uejAM3o3C7 X-Received: by 2002:a05:600c:529a:b0:485:3e00:944a with SMTP id 5b1f17b1804b1-4870f1fc5fdmr4802365e9.9.1774285372891; Mon, 23 Mar 2026 10:02:52 -0700 (PDT) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe7dc4a2sm330065515e9.5.2026.03.23.10.02.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2026 10:02:50 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: 3797fe720a37 - main - libcrypto: compile all PIC objects with -DOPENSSL_PIC -fPIC From: Jessica Clarke In-Reply-To: <69bf4832.41a59.1df6e724@gitrepo.freebsd.org> Date: Mon, 23 Mar 2026 17:02:38 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <69bf4832.41a59.1df6e724@gitrepo.freebsd.org> To: Enji Cooper X-Mailer: Apple Mail (2.3864.400.21) X-Spamd-Result: default: False [-2.67 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.77)[-0.771]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FREEFALL_USER(0.00)[jrtc27]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.42:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.42:from] X-Rspamd-Queue-Id: 4fffcg6cLXz4MZj X-Spamd-Bar: -- On 22 Mar 2026, at 01:38, Enji Cooper wrote: >=20 > The branch main has been updated by ngie: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D3797fe720a37ff9fb5b20546494ef1c4= a6c01541 >=20 > commit 3797fe720a37ff9fb5b20546494ef1c4a6c01541 > Author: Enji Cooper > AuthorDate: 2026-03-22 00:39:16 +0000 > Commit: Enji Cooper > CommitDate: 2026-03-22 01:38:49 +0000 >=20 > libcrypto: compile all PIC objects with -DOPENSSL_PIC -fPIC >=20 > This change modifies the libcrypto PIC objects to always compile = with > `-DOPENSSL_PIC -fPIC` to restore parity with the upstream build = process. > This ensures that the legacy provider is built with parity to the > upstream legacy provider. >=20 > MFC after: 12 days > Tested with: `make check` (legacy provider), `make = universe` > Fixes: 14b9955e > Differential Revision: https://reviews.freebsd.org/D44896 > --- > secure/lib/libcrypto/Makefile | 6 ------ > secure/lib/libcrypto/Makefile.inc | 3 +++ > 2 files changed, 3 insertions(+), 6 deletions(-) >=20 > diff --git a/secure/lib/libcrypto/Makefile = b/secure/lib/libcrypto/Makefile > index 738de3479987..9d484e9d480c 100644 > --- a/secure/lib/libcrypto/Makefile > +++ b/secure/lib/libcrypto/Makefile > @@ -687,12 +687,6 @@ SUBDIR.${MK_TESTS}=3D tests >=20 > .include >=20 > -.if ${MACHINE} =3D=3D "powerpc" > -# Work around "relocation R_PPC_GOT16 out of range" errors > -PICFLAG=3D -fPIC > -.endif > -PICFLAG+=3D -DOPENSSL_PIC > - > .if defined(ASM_${MACHINE_CPUARCH}) > .PATH: ${SRCTOP}/sys/crypto/openssl/${MACHINE_CPUARCH} > .if defined(ASM_amd64) > diff --git a/secure/lib/libcrypto/Makefile.inc = b/secure/lib/libcrypto/Makefile.inc > index 73c650d590ff..8f22d501e005 100644 > --- a/secure/lib/libcrypto/Makefile.inc > +++ b/secure/lib/libcrypto/Makefile.inc > @@ -12,6 +12,9 @@ CFLAGS+=3D -I${LCRYPTO_SRC}/providers/common/include > CFLAGS+=3D -I${LCRYPTO_SRC}/providers/fips/include > CFLAGS+=3D -I${LCRYPTO_SRC}/providers/implementations/include >=20 > +PICFLAG=3D -fPIC > +PICFLAG+=3D -DOPENSSL_PIC > + > .SUFFIXES: .pc > .PATH.pc: ${LCRYPTO_SRC}/exporters This isn=E2=80=99t what PICFLAG is for. Is there a reason you can=E2=80=99= t use SHARED_CFLAGS? Jessica