Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Jul 2015 16:40:58 +1000
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        Josh Paetzel <jpaetzel@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r392736 - in head/devel: . py-columnize
Message-ID:  <55B1DDFA.2010602@FreeBSD.org>
In-Reply-To: <201507231557.t6NFvtMC027398@repo.freebsd.org>
References:  <201507231557.t6NFvtMC027398@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 24/07/2015 1:57 AM, Josh Paetzel wrote:
> Author: jpaetzel
> Date: Thu Jul 23 15:57:54 2015
> New Revision: 392736
> URL: https://svnweb.freebsd.org/changeset/ports/392736
> 
> Log:
>   Welcome py-columnize to the ports tree.
>   
>   Format a simple (i.e. not nested) list into aligned columns
> 
> Added:
>   head/devel/py-columnize/
>   head/devel/py-columnize/Makefile   (contents, props changed)
>   head/devel/py-columnize/distinfo   (contents, props changed)
>   head/devel/py-columnize/pkg-descr   (contents, props changed)
> Modified:
>   head/devel/Makefile
> 
> Modified: head/devel/Makefile
> ==============================================================================
> --- head/devel/Makefile	Thu Jul 23 15:49:49 2015	(r392735)
> +++ head/devel/Makefile	Thu Jul 23 15:57:54 2015	(r392736)
> @@ -3867,6 +3867,7 @@
>      SUBDIR += py-collective.z3cform.datetimewidget
>      SUBDIR += py-colorama
>      SUBDIR += py-colorlog
> +    SUBDIR += py-columnize
>      SUBDIR += py-conditional
>      SUBDIR += py-configargparse
>      SUBDIR += py-configobj
> 
> Added: head/devel/py-columnize/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/py-columnize/Makefile	Thu Jul 23 15:57:54 2015	(r392736)
> @@ -0,0 +1,23 @@
> +# $FreeBSD$
> +
> +PORTNAME=	columnize
> +PORTVERSION=	0.3.8
> +CATEGORIES=	devel python
> +MASTER_SITES=	CHEESESHOP
> +PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
> +
> +MAINTAINER=	jpaetzel@FreeBSD.org
> +COMMENT=	Format a simple (i.e. not nested) list into aligned columns
> +
> +LICENSE=	MIT
> +
> +MY_DEPENDS=	${PYTHON_PKGNAMEPREFIX}nose>=1.0:${PORTSDIR}/devel/py-nose
> +MY_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}backports.shutil_get_terminal_size=1.0:${PORTSDIR}/devel/py-backports.shutil_get_terminal_size

nose is *extremely* unlikely to be a build or run dependency (likely
only for testing (tests_require), and backports.shutil_get_terminal_size
is *very* likely only a RUN_DEPENDS.

The packages setup.py should articulate which is which:

setup_requires = BUILD_DEPENDS
install_requires = RUN_DEPENDS
tests_require = TEST_TEPENDS

Keep in mind that the package authors may also not have declared their
dependencies correctly.

MY_DEPENDS isn't necessary either, just duplicate the dependencies for
and in each of RUN/BUILD depends.

Happy to help on IRC if you need to investigate further.

Finally, thanks for adding more Python ports!

> +BUILD_DEPENDS=	${MY_DEPENDS}
> +RUN_DEPENDS=	${MY_DEPENDS}
> +
> +USES=		python
> +USE_PYTHON=	autoplist distutils
> +
> +.include <bsd.port.mk>
> 
> Added: head/devel/py-columnize/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/py-columnize/distinfo	Thu Jul 23 15:57:54 2015	(r392736)
> @@ -0,0 +1,2 @@
> +SHA256 (columnize-0.3.8.tar.gz) = c94d9173e0cb34682b1f63d2cea5924a522ef588981a7baa6a4c08a785808555
> +SIZE (columnize-0.3.8.tar.gz) = 9464
> 
> Added: head/devel/py-columnize/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/py-columnize/pkg-descr	Thu Jul 23 15:57:54 2015	(r392736)
> @@ -0,0 +1,3 @@
> +Format a simple (i.e. not nested) list into aligned columns.
> +
> +WWW: https://github.com/rocky/pycolumnize
> 




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55B1DDFA.2010602>