From owner-svn-src-all@freebsd.org Wed Apr 20 01:35:22 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4608DB1507F; Wed, 20 Apr 2016 01:35:22 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0BA9D12EB; Wed, 20 Apr 2016 01:35:22 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-oi0-x231.google.com with SMTP id r78so27240559oie.0; Tue, 19 Apr 2016 18:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc; bh=rX/UmftAPkq7+ZmWMcqg7wsPW7+DBqSmwwoEIy7yhm4=; b=AYrkKc+a1n1pfnQsJ7180h0ltMvv0JYvCUYxjoQ0pS09ArP409Butncgn1qxngNaGw lpkX6iTrIWQMSiIBDlv9rpZrtA59g//Tg7WxoMHdRFo0f8F3FV/EPST/39mpixSB5n5x CTZQw8Hdag/CssAFQJrwzFCHUppxclf/Mjj5ObsjrynKD7Euk4zAfY/zmLqjZCqnfzZN IS9wk86fAWe3LS3F2hdhBYNsx6Kq08zwmzOKEWplRblJMtgNcMkamVieO4pRcVGVAHCj E7vCUrxJ9jWedWnjiKMEBNZZuTZk6aOpUHb1rSMURQsmkWCuHzoe3g0yMSRgurboi0NS mOkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=rX/UmftAPkq7+ZmWMcqg7wsPW7+DBqSmwwoEIy7yhm4=; b=aHC38e/Y7kb6iPVXMKXJm1Lz/fodwYqC/A3MEJXCaw+Cg1unhQWgr93iagN/torjBn KNF5xgBsOAGsEIKYrBwLpeIbLoH9nnm6YgYitjQ/hUKqSM1gmqZV+lkOwN4+MlSq0sLd nmO8ErkE5O2SgaHqGZtV3YLrnub58h8i8w7Apgv4umKBaUTYyIcrTRnX+3Yxnseh9vPY 3K28i1QcOx/v9zDncJrmeHHR9dLW5oNIFD6d/eXOcjKhDKFewjid8AqAPLOkDeFbVQxz VSdnRBnqENvKbxDMTp2qhUcXM+h3vFxYUkqO0ll1L4phf7cTHLL/JKsT0n27onPXiON3 h8sg== X-Gm-Message-State: AOPr4FXb+SZRbAOkuD/gbpn3BgX4rYz97Lakfz9E2n9zR0gxBit9tOzZpo/rYXIqQbFDXUaKsFw9+SCLMrngnQ== MIME-Version: 1.0 X-Received: by 10.157.3.97 with SMTP id 88mr2845958otv.137.1461116121374; Tue, 19 Apr 2016 18:35:21 -0700 (PDT) Received: by 10.182.156.65 with HTTP; Tue, 19 Apr 2016 18:35:21 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: <81a0edfd-67cf-5049-a4d7-f6b5e517f529@FreeBSD.org> References: <201604200105.u3K15sCP021936@repo.freebsd.org> <81a0edfd-67cf-5049-a4d7-f6b5e517f529@FreeBSD.org> Date: Wed, 20 Apr 2016 09:35:21 +0800 Message-ID: Subject: Re: svn commit: r298320 - head/sbin/sunlabel From: Marcelo Araujo To: Pedro Giffuni Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 01:35:22 -0000 2016-04-20 9:24 GMT+08:00 Pedro Giffuni : > > > On 04/19/16 20:05, Marcelo Araujo wrote: > >> Author: araujo >> Date: Wed Apr 20 01:05:54 2016 >> New Revision: 298320 >> URL: https://svnweb.freebsd.org/changeset/base/298320 >> >> Log: >> Use nitems() from sys/param.h. >> >> MFC after: 2 weeks. >> >> Modified: >> head/sbin/sunlabel/sunlabel.c >> >> Modified: head/sbin/sunlabel/sunlabel.c >> >> ============================================================================== >> --- head/sbin/sunlabel/sunlabel.c Wed Apr 20 01:03:06 2016 >> (r298319) >> +++ head/sbin/sunlabel/sunlabel.c Wed Apr 20 01:05:54 2016 >> (r298320) >> @@ -903,7 +903,7 @@ tagname(unsigned int tag) >> struct tags *tp; >> >> for (i = 0, tp = knowntags; >> - i < sizeof(knowntags) / sizeof(struct tags); >> + i < nitems(knowntags); >> i++, tp++) >> if (tp->id == tag) >> return (tp->name); >> > > Please re-indent lines like this, the complete "for" fits in one line. > (same for the others) > > Pedro. > > > @@ -921,7 +921,7 @@ flagname(unsigned int flag) >> struct tags *tp; >> >> for (i = 0, tp = knownflags; >> - i < sizeof(knownflags) / sizeof(struct tags); >> + i < nitems(knownflags); >> i++, tp++) >> if (tp->id == flag) >> return (tp->name); >> @@ -940,7 +940,7 @@ parse_tag(struct sun_disklabel *sl, int >> unsigned long l; >> >> for (i = 0, tp = knowntags; >> - i < sizeof(knowntags) / sizeof(struct tags); >> + i < nitems(knowntags); >> i++, tp++) >> if (strcmp(tp->name, tag) == 0) { >> sl->sl_vtoc_map[part].svtoc_tag = >> (uint16_t)tp->id; >> @@ -965,7 +965,7 @@ parse_flag(struct sun_disklabel *sl, int >> unsigned long l; >> >> for (i = 0, tp = knownflags; >> - i < sizeof(knownflags) / sizeof(struct tags); >> + i < nitems(knownflags); >> i++, tp++) >> if (strcmp(tp->name, flag) == 0) { >> sl->sl_vtoc_map[part].svtoc_flag = >> (uint16_t)tp->id; >> >> Done! Thanks! -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)