From owner-svn-src-all@FreeBSD.ORG  Sun Aug 23 15:10:53 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 45E7E106568C
	for <svn-src-all@FreeBSD.org>; Sun, 23 Aug 2009 15:10:53 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id 8D85B8FC0C
	for <svn-src-all@FreeBSD.org>; Sun, 23 Aug 2009 15:10:52 +0000 (UTC)
Received: (qmail invoked by alias); 23 Aug 2009 14:44:11 -0000
Received: from p54A3EA49.dip.t-dialin.net (EHLO tron.homeunix.org)
	[84.163.234.73]
	by mail.gmx.net (mp001) with SMTP; 23 Aug 2009 16:44:11 +0200
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX18KgyUaFhkKd3JDB0oTi0AhcNzAvrgs+E36xrSoEQ
	9KeTrZ8yckbcoa
Message-ID: <4A9155BA.9020808@gmx.de>
Date: Sun, 23 Aug 2009 16:44:10 +0200
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Thunderbird 2.0.0.23 (X11/20090823)
MIME-Version: 1.0
To: Bruce Evans <brde@optusnet.com.au>
References: <200908230759.n7N7xS6g051165@svn.freebsd.org>	<20090823080940.GT1292@hoeg.nl>
	<20090823230300.Q38728@delplex.bde.org>
In-Reply-To: <20090823230300.Q38728@delplex.bde.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.72
Cc: svn-src-head@FreeBSD.org, Ed Schouten <ed@80386.nl>,
	svn-src-all@FreeBSD.org, src-committers@FreeBSD.org,
	Julian Elischer <julian@FreeBSD.org>
Subject: Re: svn commit: r196451 - head/sys/netinet/ipfw
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Aug 2009 15:10:53 -0000

Bruce Evans schrieb:
> %  */
> % int
> % ipfw_init(void)
> % {
> %     int error = 0;
> 
> This variable is not really used.
> 
> Initialization in declaration.  This mainly obfuscates the non-use of the
> variable.

Rather the opposite is true:

void f(void)
{
   int error = 0; // GCC warns that error is unused
}

void g(void)
{
   int error;
   error = 0; // GCC is silent
}

In this case it does not help, because error is used. But an assignment 
halfway down the function definitely would not improve the situation.

	Christoph