From owner-svn-src-all@freebsd.org Mon Oct 12 00:20:04 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BE5FA1052C; Mon, 12 Oct 2015 00:20:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22c.google.com (mail-ig0-x22c.google.com [IPv6:2607:f8b0:4001:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5184C855; Mon, 12 Oct 2015 00:20:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igkz10 with SMTP id z10so36762036igk.1; Sun, 11 Oct 2015 17:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=6V2h8NqBJ6lH+Sz3l6olBb0TbZ68uWZ0HquqoF65khA=; b=cGGx7fjeJN6SDEM4annhWPzzxhJDdhZyqKItSKi8f9/+b54XySEBTbHYGR4K9YmLjz /vhU4y8Je2NQqflYUDHxF3XVwGKk+ERLot48RxCCnG3i4WS1UGkXXNRIEA2rOp6aF+wJ ZK3erRTDg39o4380zHulrdVyqNKl2jcXMA4P7pZXSpWzIYMupecSEl3HEn/F0H5zNA58 kaQKHn04NqqRi9B3H69yAEL5lVlW4RBwP6Tv2O4BTPJR0uCKIJ0qZflZG+Ft+RnKR5yj M/6c3a9MOpctb0/8YITu6p+Yg59yXawf0C9XaZEEZ7vJLRilhm+EXiaUas0r4FwfT/Pj EXoQ== MIME-Version: 1.0 X-Received: by 10.50.61.243 with SMTP id t19mr9031568igr.22.1444609203724; Sun, 11 Oct 2015 17:20:03 -0700 (PDT) Received: by 10.36.2.10 with HTTP; Sun, 11 Oct 2015 17:20:03 -0700 (PDT) In-Reply-To: <201510111958.t9BJwvuI069443@repo.freebsd.org> References: <201510111958.t9BJwvuI069443@repo.freebsd.org> Date: Sun, 11 Oct 2015 17:20:03 -0700 Message-ID: Subject: Re: svn commit: r289150 - head/contrib/gcc/cp From: Adrian Chadd To: "Pedro F. Giffuni" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 00:20:04 -0000 Heya! How'd you test this? Sean is reporting (on irc) there's some weirdness after this commit. -a On 11 October 2015 at 12:58, Pedro F. Giffuni wrote: > Author: pfg > Date: Sun Oct 11 19:58:57 2015 > New Revision: 289150 > URL: https://svnweb.freebsd.org/changeset/base/289150 > > Log: > Correct handling of enum attributes with g++ > > From OpenBSD's commit log: > > This was responsible for memory corruption with recent versions > of Mesa where c and c++ code share a header with a packed enum type. > > Reference: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39219 > > Obtained from: OpenBSD (CVS rev. 1.2) > MFC after: 1 week > > Modified: > head/contrib/gcc/cp/parser.c > > Modified: head/contrib/gcc/cp/parser.c > ============================================================================== > --- head/contrib/gcc/cp/parser.c Sun Oct 11 19:30:09 2015 (r289149) > +++ head/contrib/gcc/cp/parser.c Sun Oct 11 19:58:57 2015 (r289150) > @@ -10906,6 +10906,7 @@ cp_parser_enum_specifier (cp_parser* par > if (cp_parser_allow_gnu_extensions_p (parser)) > { > tree trailing_attr = cp_parser_attributes_opt (parser); > + trailing_attr = chainon (trailing_attr, attributes); > cplus_decl_attributes (&type, > trailing_attr, > (int) ATTR_FLAG_TYPE_IN_PLACE); >