From owner-cvs-src@FreeBSD.ORG  Mon Oct  4 16:31:12 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D0D8416A4CE; Mon,  4 Oct 2004 16:31:12 +0000 (GMT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3A83743D48; Mon,  4 Oct 2004 16:31:12 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.1/8.13.1) with ESMTP id i94GUs7H050892;
	Mon, 4 Oct 2004 09:30:58 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200410041630.i94GUs7H050892@gw.catspoiler.org>
Date: Mon, 4 Oct 2004 09:30:54 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
To: imp@bsdimp.com
In-Reply-To: <20041004.095538.105191591.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: phk@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_shutdown.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Oct 2004 16:31:13 -0000

On  4 Oct, M. Warner Losh wrote:
> In message: <200410041313.i94DDN1w064795@repoman.freebsd.org>
>             Poul-Henning Kamp <phk@FreeBSD.org> writes:
> : phk         2004-10-04 13:13:23 UTC
> : 
> :   FreeBSD src repository
> : 
> :   Modified files:
> :     sys/kern             kern_shutdown.c 
> :   Log:
> :   Change the perfectly precise message
> :          printf("No buffers busy after final sync");
> :   to
> :          printf("All buffers synced.");
> :   in order to not leave the users wondering if there should be.

I was going to suggest "All buffers previously synced." as being more
precise, or maybe "Buffers already synced", but I didn't want to start
another bikeshed discussion.

> Any not reason to delete
>  	printf("All buffers synced.");
> entirely?

When I added the syncer code to (hopefully) do the final sync as part of
the syncer shutdown, I added this alternative printf so that the
"normal" shutdown sequence could be distinguished from the unexpected
case.  Without this change, boot() would always have printed
	"Syncing disks, buffers remaining... 0"

One could make the argument for being silent in the "normal" case and
only printing a message when something unexpected occurs, but I think
this would also apply to most of the other kernel shutdown messages.