Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Nov 2018 19:23:50 +0000 (UTC)
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r340078 - head/sys/netpfil/pf
Message-ID:  <201811021923.wA2JNogn008546@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kp
Date: Fri Nov  2 19:23:50 2018
New Revision: 340078
URL: https://svnweb.freebsd.org/changeset/base/340078

Log:
  pf: Fix build if INVARIANTS is not set
  
  r340061 included a number of assertions pf_frent_remove(), but these assertions
  were the only use of the 'prev' variable. As a result builds without
  INVARIANTS had an unused variable, and failed.
  
  Reported by:	vangyzen@

Modified:
  head/sys/netpfil/pf/pf_norm.c

Modified: head/sys/netpfil/pf/pf_norm.c
==============================================================================
--- head/sys/netpfil/pf/pf_norm.c	Fri Nov  2 19:14:15 2018	(r340077)
+++ head/sys/netpfil/pf/pf_norm.c	Fri Nov  2 19:23:50 2018	(r340078)
@@ -445,7 +445,9 @@ pf_frent_insert(struct pf_fragment *frag, struct pf_fr
 void
 pf_frent_remove(struct pf_fragment *frag, struct pf_frent *frent)
 {
+#ifdef INVARIANTS
 	struct pf_frent *prev = TAILQ_PREV(frent, pf_fragq, fr_next);
+#endif
 	struct pf_frent *next = TAILQ_NEXT(frent, fr_next);
 	int index;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811021923.wA2JNogn008546>