From owner-freebsd-current@FreeBSD.ORG Tue Jan 8 07:50:58 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 708BCD0F; Tue, 8 Jan 2013 07:50:58 +0000 (UTC) (envelope-from mr.kodiak@gmail.com) Received: from mail-ie0-f178.google.com (mail-ie0-f178.google.com [209.85.223.178]) by mx1.freebsd.org (Postfix) with ESMTP id 2883DFDC; Tue, 8 Jan 2013 07:50:57 +0000 (UTC) Received: by mail-ie0-f178.google.com with SMTP id c12so131424ieb.37 for ; Mon, 07 Jan 2013 23:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=BpQmNpmGwE2GHkNFC3ymKfCTVbncF75wO93grqGTuPE=; b=njoNP4F6gmWxcdWKAz6W924xYVxltuValiMU49U9jHG9jMPuJx/aIecwSrzfys/Xs9 Iav8G5mNU+i2ez4K4ac+tnpHYNL2H2XUKiew8y6JeY5FYjcbrZn5XalNKEENMFLqSC8h KV5QQhDDhgoiV85pGMqdZOfIe65cBxPSxytrci3Gi7Og1pzPNwnjqfiyU3A9TrIT7fRq wB0xk2+kUKsgenPLuDvQh2buSkvit1410Wamsg0NfyqcaT6OY55r8lPeG+Vdlax0OzMS +tJThlvDzWsatzEYzfKwy6UpO0ulwpBkVN+iuu89lJiOWnwl4MD5Ml6xux2VoS7+Tu+G B/Xg== X-Received: by 10.50.207.70 with SMTP id lu6mr8262385igc.50.1357631457424; Mon, 07 Jan 2013 23:50:57 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.142.198 with HTTP; Mon, 7 Jan 2013 23:50:27 -0800 (PST) In-Reply-To: References: From: Bryan Venteicher Date: Tue, 8 Jan 2013 01:50:27 -0600 X-Google-Sender-Auth: qRaySTD3Ov1BpPZvvI8HJn_FpAM Message-ID: Subject: Re: VirtIO in GENERIC To: Bryan Venteicher Content-Type: text/plain; charset=ISO-8859-1 Cc: Jim Harris , freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2013 07:50:58 -0000 On Mon, Dec 17, 2012 at 1:17 AM, Bryan Venteicher wrote: > On Sun, Dec 16, 2012 at 11:06 PM, Jim Harris wrote: >> >> >> On Sun, Dec 16, 2012 at 6:53 PM, Andrew Thompson >> wrote: >>> >>> On 17 December 2012 13:17, Bryan Venteicher wrote: >>> >>> > There's been lots of requests to have VirtIO in GENERIC for i386 and >>> > amd64. Anybody have any issues or concerns with this or the patch at >>> > [1]. This also removes the kludge that was introduced in r239009. >>> > >>> > I've compiled LINT for i386 and amd64 so hopefully there won't be any >>> > surprise breakages. >>> > >>> > [1] http://people.freebsd.org/~bryanv/patches/virtio.generic.patch >>> >>> >>> It would be great to have the drivers enabled. You do not need the >>> sys/conf/files changes, the common and arch files are combined. >>> >> >> Removing the virtio files from sys/conf/files ensures these drivers can only >> be specified in x86 kernel configuration files. r239009 added these lines >> to sys/conf/files, but Bryan's patch does it more correctly. >> >> The only question I have is the GENERIC changes where "device virtio" is >> added - it says it is required, but should this instead say it's required >> for any of the other drivers in this section? >> > > Yes, that wording could be improved; will update the patch in the morning. > Hmm .. on second thought, I think 'required' is sufficiently clear on its own that it applies only to this section. Other nearby sections (USB, sound) use the word also. For the time being, I still intend to add VirtIO only to i386 and amd64 GENERIC. ARM and PPC64 can join the club later once I have a chance to test/debug them on QEMU. I'd like to commit this this weekend if nobody raises any objections. >> -Jim >>