From nobody Mon Aug 3 14:30:45 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hDJxd3kPGz6nV77 for ; Mon, 03 Aug 2026 14:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hDJxd1gpwz3t3x for ; Mon, 03 Aug 2026 14:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785767445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hDjgTXQ/I75NPX9TPeiH/SpoZ3DLOIdrfKtZhT+1TzE=; b=ytCiUer5mfk1VKuyKQWowphvZUsLT8xA6/CVdPac5hKjEwQmFGAp1WP5qguMOR6QpZyYFV xjJQJ/+Uo8z7J9GECUW18IqPCLx4bHog6QvRV0q9zup9YmpBIHLDLKU5Gv0ElSXT8p6Y+D +wNXsiFFeJPr9yCpmcMGH4JO4pSon6gm0bIkE/Hn+GZwVmOcbjqJqgoPAgva21cuRpZl3e x+06z+a7pzp1DVI81tVhFkoo743p69DGdwmVpUowGaklbrBSl9TeQ5m+MGYy9Y4yAX2fBL l1bju1qtybY7bUV0ZH1tjZJ25Sp9RqCL+F481yQfyJhhXFMEA9iMOO/QY62/jA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785767445; a=rsa-sha256; cv=none; b=tuOb7gfhu78O4OU2mT9z/pdwNOnrXweb9uDpbKmU7eamft99T18bAxtpXH7XNzeE2uCAg2 NQYCamjnRnw+MK1vBhiys3Bo2o/YumoADY+2Ek7aqLZL+QtHU76gJqHhT7mPA+8BLiWYu2 OkTV3PfKQFacvQG1bIaQ0B/dhm2YGyxH1G2rH2EAVzXLuNLgMIHXS7X2ed4HmH87axbEPF C+dUS/s4YYbZimOwJ6OE1Qh/6rI54jfZLQJQH4LL2Uq/cX2/xlENObo1Nc4QPxlRpmzq3C ggLEajtdum8w3UaMLBmEQsv8NVkc0WXi5rmO/2BTknEtZmzGLNtlkMjfB+I9Lg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785767445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hDjgTXQ/I75NPX9TPeiH/SpoZ3DLOIdrfKtZhT+1TzE=; b=hOTJHEXtm/p0sjw7qGQvuPP5EjqNOodVXRcxiawiYKpX9D9MDj810Z2on8jNTsh1ZQ7t/v iNrTzL6GVbp98oSNpFjiG7G9o/tG/q2+euorBQCEYBBn8l4zMUWTQCrvmH1QaR2R2Ylazo +q6WIVutQkNPZCXj3mHB9KrpFPiHGWuWmY/5WNSbMMLsxyGnLaU56G76IsUJ5909uz63U4 Gz/jeZM7cfnbI5HWCi9yO9Yf/A0s7vg02QCPXTQO5te5V9boF/kj1hfr3ldXoX3TKP0exZ D00UPu7IR8K5UrE01Xx8E/BEEKGdPIemHLMxYwVSVL+ReffxUt0f513hbtDeNQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hDJxd0fFgz148R for ; Mon, 03 Aug 2026 14:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36aaa by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 03 Aug 2026 14:30:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Lexi Winter Subject: git: 2296c39a9ebc - main - xinstall: Const correctness for C23 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2296c39a9ebc4f081d90b6554d8839e8cde8490a Auto-Submitted: auto-generated Date: Mon, 03 Aug 2026 14:30:45 +0000 Message-Id: <6a70a615.36aaa.46490793@gitrepo.freebsd.org> The branch main has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=2296c39a9ebc4f081d90b6554d8839e8cde8490a commit 2296c39a9ebc4f081d90b6554d8839e8cde8490a Author: Lexi Winter AuthorDate: 2026-08-03 14:07:09 +0000 Commit: Lexi Winter CommitDate: 2026-08-03 14:07:09 +0000 xinstall: Const correctness for C23 On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr() now implements the C23 behaviour where passing a const pointer to strchr() also returns a const pointer. This breaks xinstall during the bootstrap build, since it assumes the return value is always a mutable pointer. As the returned pointer is never used to modify the value, fix this by making the temporary variable const. MFC after: 1 week Reviewed by: ray, markj, emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58492 --- usr.bin/xinstall/xinstall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr.bin/xinstall/xinstall.c b/usr.bin/xinstall/xinstall.c index 7636da20153b..36af3528cae6 100644 --- a/usr.bin/xinstall/xinstall.c +++ b/usr.bin/xinstall/xinstall.c @@ -819,7 +819,8 @@ install(const char *from_name, const char *to_name, u_long fset, u_int flags) char backup[MAXPATHLEN], pathbuf[MAXPATHLEN], tempfile[MAXPATHLEN]; struct stat from_sb, temp_sb, to_sb; struct timespec tsb[2]; - char *digestresult, *p; + char *digestresult; + const char *p; int from_fd, temp_fd, to_fd, serrno; bool devnull, exists, files_match, ispipe, stripped;