From owner-svn-ports-head@freebsd.org Tue Jan 8 17:23:07 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 744C41484830; Tue, 8 Jan 2019 17:23:07 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 10F576E89B; Tue, 8 Jan 2019 17:23:06 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.0.101] (97-123-6-172.albq.qwest.net [97.123.6.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id A53FD1AFCF8; Tue, 8 Jan 2019 10:21:45 +0000 (UTC) Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> From: Sean Bruno Openpgp: preference=signencrypt Autocrypt: addr=sbruno@freebsd.org; prefer-encrypt=mutual; keydata= mQENBFk+0UEBCADaf4bgxxKvMOhRV5NPoGWRCCGm49d6+1VFNlQ77WsY/+Zvf95TPULdRlnG w648KfxWt7+O3kdKhdRwnqlXWC7zA2Qt0dRE1yIqOGJ4jp4INvp/bcxWzgr0aoKOjrlnfxRV bh+s0rzdZt6TsNL3cVYxkC8oezjaUkHdW4mFJU249U1QJogkF8g0FeKNfEcjEkwJNX6lQJH+ EzCWT0NCk6J+Xyo+zOOljxPp1OUfdvZi3ulkU/qTZstGVWxFVsP8xQklV/y3AFcbIYx6iGJ4 5L7WuB0IWhO7Z4yHENr8wFaNYwpod9i4egX2BugbrM8pOfhN2/qqdeG1L5LMtXw3yyAhABEB AAG0N1NlYW4gQnJ1bm8gKEZyZWVCU0QgRGV2ZWxvcGVyIEtleSkgPHNicnVub0BmcmVlYnNk Lm9yZz6JAVQEEwEKAD4WIQToxOn4gDUE4eP0ujS95PX+ibX8tgUCWT7RQQIbAwUJBaOagAUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAAKCRC95PX+ibX8ttKTCACFKzRc56EBAlVotq02EjZP SfX+unlk6AuPBzShxqRxeK+bGYVCigrYd1M8nnskv0dEiZ5iYeND9HIxbpEyopqgpVTibA7w gBXaZ7SOEhNX1wXwg14JrralfSmPFMYni+sWegPMX/zwfAsn1z4mG1Nn44Xqo3o7CfpkMPy6 M5Bow2IDzIhEYISLR+urxs74/aHU35PLtBSDtu18914SEMDdva27MARN8mbeCDbuJVfGCPWy YHuy2t+9u2Zn5Dd+t3sBXLM9gpeaMm+4x6TNPpESygbVdh4tDdjVZ9DK/bWFg0kMgfZoaq6J l0jNsQXrZV3bzYNFbVw04pFcvA2GIJ7xuQENBFk+0UEBCADIXBmQOaKMHGbc9vwjhV4Oj5aZ DdhNedn12FVeTdOXJvuTOusgxS29lla0RenHGDsgD08UiFpasBXWq/E+BhQ19d+iRbLLR17O KKc1ZGefoVbLARLXD68J5j4XAyK+6k2KqBLlqzAEpHTzsksM9naARkVXiEVcrt6ciw0FSm8n kuK3gDKKe93XfzfP+TQdbvvzJc7Fa+appLbXz61TM1aikaQlda8bWubDegwXbuoJdB34xU1m yjr/N4o+raL0x7QrzdH+wwgrTTo+H4S2c1972Skt5K5tbxLowfHicRl23V8itVQr3sBtlX4+ 66q+Apm7+R36bUS/k+G45Sp6iPpxABEBAAGJATwEGAEKACYWIQToxOn4gDUE4eP0ujS95PX+ ibX8tgUCWT7RQQIbDAUJBaOagAAKCRC95PX+ibX8trrIB/9Pljqt/JGamD9tx4dOVmxSyFg9 z2xzgklTLuDgS73MM120mM7ao9AQUeWiSle/H0UCK7xPOzC/aeUC4oygDQKAfkkNbCNTo3+A qDjBRA8qx0e9a/QjDL+RFgD4L5kLT4tToY8T8HaBp8h03LBfk510IaI8oL/Jg7vpM3PDtJMW tUi2H+yNFmL3NfM2oBToWKLFsoP54f/eeeImrNnrlLjLHPzqS+/9apgYqX2Jwiv3tHBc4FTO GuY8VvF7BpixJs8Pc2RUuCfSyodrp1YG1kRGlXAH0cqwwr0Zmk4+7dZvtVQMCl6kS6q1+84q JwtItxS2eXSEA4NO0sQ3BXUywANh Message-ID: Date: Tue, 8 Jan 2019 10:23:05 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190103232315.GA10712@urd.tobik.me> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kmwYskeMvL8rYGqpg5gtXXloRd1cY91hD" X-Rspamd-Queue-Id: 10F576E89B X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.85 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.86)[-0.862,0]; ASN(0.00)[asn:36236, ipnet:199.102.76.0/22, country:US]; NEURAL_HAM_LONG(-0.99)[-0.991,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 17:23:07 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kmwYskeMvL8rYGqpg5gtXXloRd1cY91hD Content-Type: multipart/mixed; boundary="1xRTm9mB04oZGDNf2NAQlskitXBnPWH9M"; protected-headers="v1" From: Sean Bruno To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> In-Reply-To: <20190103232315.GA10712@urd.tobik.me> --1xRTm9mB04oZGDNf2NAQlskitXBnPWH9M Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 1/3/19 4:23 PM, Tobias Kortkamp wrote: >> >> On 1/3/19 2:54 PM, Tobias Kortkamp wrote: >>>> +USE_QT=3D buildtools \ >>> Does clementine-player, a music player, really need qt5-buildtools >>> at runtime or should this be buildtools_build instead? >>> >>>> + concurrent \ >>>> + core \ >>>> dbus \ >>>> gui \ >>>> imageformats \ >>>> - qmake_build \ >>>> linguist_build \ >>>> - moc_build \ >>>> network \ >>>> opengl \ >>>> - qtestlib \ >>>> - rcc_build \ >>>> + qmake_build \ >>>> + testlib \ >>> Same here. Does it really need qt5-testlib at runtime? >>> >> Probably not? >> >> sean >> > So I guess they are not needed at runtime. Will you change them > to build dependencies? Yeah, I'll look at it today. Thanks! sean --1xRTm9mB04oZGDNf2NAQlskitXBnPWH9M-- --kmwYskeMvL8rYGqpg5gtXXloRd1cY91hD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlw03HlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LYU+wf+KTgMZ/MCIhzjo1ssV3cS/iIs8bXzilAbG8QRWp1vEAwLSXnK8AO4cjKY WQ6qwzn/4yva0KKGt7kHKdkX3ooRGDBmuWf3KwvB+Q+4+vdTj0ZiPHSCRbWTzVlY nL7Zpyri1YbTtkNZKe0izmVq6pSE/T4ksJBK6b6Qrfn7vfKlGNBXfapSe2HeMt3T w7lfenOpy71/HgRSECCNjmc2TBY47D5IyrbBJHz/3NggiVKwT6+P55Or2SJTg+qU CMSjSEqw8FwQEiioFnxaSVRrWj294hpectDsXShhqpW7PKdR+/YiU2L2m5mSQRtD NiXBJlzGIaGrvH0ITdfwAg2yS+5/Bg== =L4ek -----END PGP SIGNATURE----- --kmwYskeMvL8rYGqpg5gtXXloRd1cY91hD--