From owner-svn-src-all@FreeBSD.ORG  Sun Nov 11 17:18:51 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 148041E7E;
 Sun, 11 Nov 2012 17:18:51 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
 [209.85.220.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 54DBE8FC95;
 Sun, 11 Nov 2012 16:39:58 +0000 (UTC)
Received: by mail-pa0-f54.google.com with SMTP id bi1so3969766pad.13
 for <multiple recipients>; Sun, 11 Nov 2012 08:39:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:content-type;
 bh=c8LCpaAnw2Ji0Z6To+STrpcSFkFsUZa9NZXGI7fp1F4=;
 b=Mj7gDjWhzsNPVe6+cVx1qZMgNtXn/dzVcWLNwKwMbmkRyDtmZ/pPDoYUSj6CkPhw2S
 znidP/QPEn4Ns+OTH2O9kkWI0Tp4KXZc3FjAutqNvorIFEE0CavP4D3l8AJEzTp1d40Y
 SK0wlywRhjNFKvGATfPTRkNE3UlOWEu6u2TshC7gz7buXvtvkY3wnQNFUKi8cq3tJscc
 p0I50n+4fvdBi20H45YzXaWSQJJIEpCeYLuA4S5N5g4l7dmRwhxSjngfP79XKGqjpXqq
 dlQNKKh0DF6uYPVBG3lvPVDp5Q1vNTp4DlfFNgMC16o53lU5mvfEKvNTPzZsQySXXWsa
 U8mw==
MIME-Version: 1.0
Received: by 10.68.137.41 with SMTP id qf9mr50298621pbb.103.1352651997958;
 Sun, 11 Nov 2012 08:39:57 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.68.124.130 with HTTP; Sun, 11 Nov 2012 08:39:57 -0800 (PST)
In-Reply-To: <201211110034.qAB0YBFn052472@svn.freebsd.org>
References: <201211110034.qAB0YBFn052472@svn.freebsd.org>
Date: Sun, 11 Nov 2012 08:39:57 -0800
X-Google-Sender-Auth: bYKR7OkWuIgaUVsgE9MwcrJuBRI
Message-ID: <CAJ-VmokqKQkh9p0aR=n0AsB-3fzoqknf6wm7vjN_-s+KEzUOhw@mail.gmail.com>
Subject: Re: svn commit: r242881 - head/sys/dev/ath
From: Adrian Chadd <adrian@freebsd.org>
To: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Nov 2012 17:18:51 -0000

Damnit, I commited the wrong file. I meant if_ath.c instead of if_ath_tx.c.

Thanks for pointing it out.



Adrian

On 10 November 2012 16:34, Adrian Chadd <adrian@freebsd.org> wrote:
> Author: adrian
> Date: Sun Nov 11 00:34:10 2012
> New Revision: 242881
> URL: http://svnweb.freebsd.org/changeset/base/242881
>
> Log:
>   Don't call av_set_tim() if it's NULL.
>
>   This happens during a scan in STA mode; any queued data frames will
>   be power save queued but as there's no TIM in STA mode, it panics.
>
>   This was introduced by me when I disabled my driver-aware power save
>   handling support.
>
> Modified:
>   head/sys/dev/ath/if_ath_tx.c
>
> Modified: head/sys/dev/ath/if_ath_tx.c
> ==============================================================================
> --- head/sys/dev/ath/if_ath_tx.c        Sat Nov 10 22:37:06 2012        (r242880)
> +++ head/sys/dev/ath/if_ath_tx.c        Sun Nov 11 00:34:10 2012        (r242881)
> @@ -1236,6 +1236,8 @@ ath_tx_setds(struct ath_softc *sc, struc
>         struct ath_desc *ds = bf->bf_desc;
>         struct ath_hal *ah = sc->sc_ah;
>
> +       bzero(bf->bf_desc, sc->sc_tx_desclen * bf->bf_nseg);
> +
>         ath_hal_setuptxdesc(ah, ds
>                 , bf->bf_state.bfs_pktlen       /* packet length */
>                 , bf->bf_state.bfs_hdrlen       /* header length */