From owner-svn-src-all@FreeBSD.ORG Sat Jun 23 00:37:33 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D306106572C; Sat, 23 Jun 2012 00:37:33 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id EB3538FC14; Sat, 23 Jun 2012 00:37:32 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q5N0bWoO009248; Sat, 23 Jun 2012 00:37:32 GMT (envelope-from delphij@svn.freebsd.org) Received: (from delphij@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q5N0bW0o009246; Sat, 23 Jun 2012 00:37:32 GMT (envelope-from delphij@svn.freebsd.org) Message-Id: <201206230037.q5N0bW0o009246@svn.freebsd.org> From: Xin LI Date: Sat, 23 Jun 2012 00:37:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org X-SVN-Group: stable-9 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r237464 - in stable: 7/usr.bin/makewhatis 8/usr.bin/makewhatis 9/usr.bin/makewhatis X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2012 00:37:33 -0000 Author: delphij Date: Sat Jun 23 00:37:32 2012 New Revision: 237464 URL: http://svn.freebsd.org/changeset/base/237464 Log: MFC r237348: Currently the code uses gzFile * for a zlib file descriptor, which is not correct. The code works by accident because gzFile is currently defined as void *, and internally it would be casted from or to its real type. A newer version of zlib will instead define it as a pointer to a specific type pointer (namely, struct gzFile_s *). This therefore would cause stricter checks and compiler would catch this type mismatch. This change does not cause any changes to the resulting binary, as validated with md5(1). Modified: stable/9/usr.bin/makewhatis/makewhatis.c Directory Properties: stable/9/usr.bin/makewhatis/ (props changed) Changes in other areas also in this revision: Modified: stable/7/usr.bin/makewhatis/makewhatis.c stable/8/usr.bin/makewhatis/makewhatis.c Directory Properties: stable/7/usr.bin/makewhatis/ (props changed) stable/8/usr.bin/makewhatis/ (props changed) Modified: stable/9/usr.bin/makewhatis/makewhatis.c ============================================================================== --- stable/9/usr.bin/makewhatis/makewhatis.c Fri Jun 22 22:59:42 2012 (r237463) +++ stable/9/usr.bin/makewhatis/makewhatis.c Sat Jun 23 00:37:32 2012 (r237464) @@ -693,7 +693,7 @@ enum { STATE_UNKNOWN, STATE_MANSTYLE, ST static void process_page(struct page_info *page, char *section_dir) { - gzFile *in; + gzFile in; char buffer[4096]; char *line; StringList *names;