Date: Thu, 5 Dec 2019 11:21:29 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: John Baldwin <jhb@FreeBSD.org> Cc: rgrimes@FreeBSD.org, Vincenzo Maffione <vmaffione@FreeBSD.org>, Ian Lepore <ian@FreeBSD.org>, src-committers <src-committers@FreeBSD.org>, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r355301 - head/usr.sbin/bhyve Message-ID: <201912051921.xB5JLTMk045371@gndrsh.dnsmgr.net> In-Reply-To: <a6847442-59bf-a1e5-2d3c-40e51814570a@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 12/4/19 9:35 PM, Rodney W. Grimes wrote: > >> I see, thanks for the pointers. > >> It looks like cfmakeraw() and tcsetattr() were what I was looking for. > >> A bhyve-specific printf wrapper looks the right solution to me. > >> I can try to sketch a patch for you guys to review, if that's useful. > >> > >> Cheers, > >> Vincenzo > > > > Meanwhile could you please revert the commit, and add a note to > > D22552 to the effects that this was not the right solution? > > I don't think we have to revert as it isn't that big of a deal. Just > fixing it going forward is probably fine. I disagree. Not reverting this leads to a bunch of un-needed changes in the forward moving review, clouding the view of what is really being changed in that new review which is now a mix of undoing this and adding a new set of macros to deal with end of line. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912051921.xB5JLTMk045371>