Date: Mon, 21 Dec 2015 11:01:36 -0800 From: John Baldwin <jhb@freebsd.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc) Message-ID: <3659799.xE9v788p8Q@ralph.baldwin.cx> In-Reply-To: <8E98A82D-C36F-4863-8BE4-81288735F3A1@gmail.com> References: <8E98A82D-C36F-4863-8BE4-81288735F3A1@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, December 19, 2015 01:05:36 PM NGie Cooper wrote: > Hi John, > =09I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and ra= n into the -Wsign-compare issue below when running make libraries with = buildworld, because it=E2=80=99s building libkvm with gcc 4.2.1 :/=E2=80= =A6 I=E2=80=99ve tried bootstrapping with clang/clang37, but haven=E2=80= =99t been able to yet. I=E2=80=99ll try installing 10.2-RELEASE via fre= ebsd-update so I can use clang instead of gcc. > Thanks! > -NGie We don't actually support going from 9 to 11. However, these constants= should probably be explicitly unsigned anyway. I haven't tested this a= t all, but something like this: Index: head/lib/libkvm/kvm_i386.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- head/lib/libkvm/kvm_i386.h (revision 292553) +++ head/lib/libkvm/kvm_i386.h (working copy) @@ -57,8 +57,8 @@ #define I386_PG_PS 0x080 #define I386_PG_FRAME_PAE (0x000ffffffffff000ull) #define I386_PG_PS_FRAME_PAE (0x000fffffffe00000ull) -#define I386_PG_FRAME (0xfffff000) -#define I386_PG_PS_FRAME (0xffc00000) +#define I386_PG_FRAME (0xfffff000u) +#define I386_PG_PS_FRAME (0xffc00000u) =20 #ifdef __i386__ _Static_assert(PAGE_SHIFT =3D=3D I386_PAGE_SHIFT, "PAGE_SHIFT mismatch= "); --=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3659799.xE9v788p8Q>