From owner-dev-commits-src-main@freebsd.org Sun Jan 17 03:18:37 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2AE734D91B1; Sun, 17 Jan 2021 03:18:37 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DJKrD1cqLz3qdQ; Sun, 17 Jan 2021 03:18:35 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 10H3ISxp056103; Sat, 16 Jan 2021 19:18:28 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 10H3ISUj056102; Sat, 16 Jan 2021 19:18:28 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202101170318.10H3ISUj056102@gndrsh.dnsmgr.net> Subject: Re: git: 7e4eca7136ea - main - Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on remote filesystems. Discussed this with Brooks and he can't find evidence that provoked the change in 2005. If anything gets broken I will fix it in a dif In-Reply-To: <202101152044.10FKiUS3006617@gitrepo.freebsd.org> To: Gleb Smirnoff Date: Sat, 16 Jan 2021 19:18:27 -0800 (PST) CC: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4DJKrD1cqLz3qdQ X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd@gndrsh.dnsmgr.net X-Spamd-Result: default: False [1.78 / 15.00]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; NEURAL_SPAM_SHORT(0.99)[0.993]; LONG_SUBJ(1.88)[251]; SPAMHAUS_ZRD(0.00)[69.59.192.140:from:127.0.2.255]; RCVD_TLS_LAST(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[69.59.192.140:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2021 03:18:37 -0000 > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=7e4eca7136eaa35e15f67682468f09aa7127b543 > > commit 7e4eca7136eaa35e15f67682468f09aa7127b543 > Author: Gleb Smirnoff > AuthorDate: 2021-01-11 20:13:41 +0000 > Commit: Gleb Smirnoff > CommitDate: 2021-01-15 20:44:06 +0000 > > Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on > remote filesystems. Discussed this with Brooks and he can't find > evidence that provoked the change in 2005. If anything gets broken > I will fix it in a different way, not via rc sequence change. This is because /etc/rc.d/tmp has this line: if ! /bin/df /tmp | grep -q "^/dev/md[0-9].* /tmp"; then and when your doing NFS boots with seperate /usr you do not have /usr/bin/grep to run that line. Almost always the reason things have a REQUIRE: mountcritremote is that they use some commands from /usr. > Discussed with: brooks > Reviewed by: ngie > Differential Revision: https://reviews.freebsd.org/D28097 > --- > libexec/rc/rc.d/tmp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libexec/rc/rc.d/tmp b/libexec/rc/rc.d/tmp > index 3b75ec0338ef..a61321e058ee 100755 > --- a/libexec/rc/rc.d/tmp > +++ b/libexec/rc/rc.d/tmp > @@ -28,7 +28,7 @@ > # > > # PROVIDE: tmp > -# REQUIRE: mountcritremote > +# REQUIRE: mountcritlocal > > . /etc/rc.subr > > -- Rod Grimes rgrimes@freebsd.org