From owner-freebsd-pkg@FreeBSD.ORG Wed Feb 18 22:34:17 2015 Return-Path: Delivered-To: freebsd-pkg@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D76B0B55 for ; Wed, 18 Feb 2015 22:34:17 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 92883A32 for ; Wed, 18 Feb 2015 22:34:17 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 9C01EBDC2E; Wed, 18 Feb 2015 23:34:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=mat.cc; h=date:from:to :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=plouf; bh=fNujRtTHmXs hku8NODQL1ZJLGe8=; b=0fVmugx59IurOmcSJEIo3QDQduiz5h2E+0rcSQ6hata zkH8mt+MsLPz0AdkgQO9Wt0Ivi6I6/y7kdNWZX/gHy1XxIJ8C/UHaFu/wEr30V9a xoF8pg7IU8kcQaIC4NWxNtfzWqb5jGofysKEcvuxk0t5SmJV4sp0wLvR34zNRaBo = Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id 7593FBDC24; Wed, 18 Feb 2015 23:34:15 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id 70AA326BABB2; Wed, 18 Feb 2015 23:34:00 +0100 (CET) Date: Wed, 18 Feb 2015 23:34:00 +0100 From: Mathieu Arnold To: Victor Sudakov , freebsd-pkg@freebsd.org Subject: Re: "poudriere distclean" complains about /etc/make.conf Message-ID: In-Reply-To: <20150218163739.GA24716@admin.sibptus.tomsk.ru> References: <20150217043049.GA68755@admin.sibptus.tomsk.ru> <20150218163739.GA24716@admin.sibptus.tomsk.ru> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-BeenThere: freebsd-pkg@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Binary package management and package tools discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:34:17 -0000 +--On 18 f=C3=A9vrier 2015 22:37:39 +0600 Victor Sudakov = wrote: | Mathieu Arnold wrote: |> |=20 |> | I have the following construct in /etc/make.conf but not in |> | /usr/local/etc/poudriere.d/make.conf: |> |=20 |> | .if ${.CURDIR:M*/mail/spamassassin} && ${HOST} =3D=3D = "relay.sibptus.ru" |> | EXTRA_PATCHES+=3D/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1 |> | .endif |> |=20 |> | When I run "poudriere distclean", it complains about this construct:=20 |> |=20 |> | WARNING (mail/spamassassin): "/etc/make.conf", line 15: |> | Malformed conditional (${.CURDIR:M*/mail/spamassassin} && ${HOST} = =3D=3D |> | "relay.sibptus.ru") WARNING (mail/spamassassin): |> | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING |> | (mail/spamassassin): make: fatal errors encountered -- cannot continue |> |=20 |> | I have two questions. |> |=20 |> | 1. Why does it complain? The conditional seems legit. |>=20 |> It seems like it is, but it is not, it should be: |>=20 |> .if !empty(.CURDIR:M*/mail/spamassassin) && ${HOST} =3D=3D = "relay.sibptus.ru" |> EXTRA_PATCHES+=3D/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1 |> .endif |>=20 |> or |>=20 |> .if ${.CURDIR:M*/mail/spamassassin} !=3D "" && ${HOST} =3D=3D |> "relay.sibptus.ru" |=20 | Sorry, Mathieu, your advice does not help: |=20 | [root@svn ~] poudriere distclean -y | [00:00:00] =3D=3D=3D=3D>> Gathering all expected distfiles for ports tree | 'default' WARNING (mail/spamassassin): "/etc/make.conf", line 15: | Malformed conditional (${.CURDIR:M*/mail/spamassassin} !=3D "" && ${HOST} | =3D=3D "relay.sibptus.ru") WARNING (mail/spamassassin): | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING | (mail/spamassassin): make: fatal errors encountered -- cannot continue=20 Ah, yes, HOST is not defined, it's why it fails, you need to add: HOST?=3D before that line, because you can't compare an undefined variable with anything. --=20 Mathieu Arnold