From owner-svn-src-all@FreeBSD.ORG Mon Aug 9 00:26:08 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DBCA1106566B; Mon, 9 Aug 2010 00:26:07 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 409138FC0A; Mon, 9 Aug 2010 00:26:06 +0000 (UTC) Received: by qwg5 with SMTP id 5so5667370qwg.13 for ; Sun, 08 Aug 2010 17:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=XuSMSxdA8ElXCwQLdjXWxXVPkXS1su0j/lMFuIo4r4o=; b=Gz3f2e1I+V0hwWZmZH5z41W9Jg6SfVwhBfjODsZhrgQr4tW5e0MWWK03+MFfwJFSos 2orA1jkns2jvdRYXZ3C31quPPV2nPoTf1Aqs3bzZdyW/8sCpPJwpOiZpsUZsp4vxdtzr hOOgzurOqYWTeHlXuVaxx+5IG4YBQz3LigKwg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=N4amAYP+olhaXQ85Nf0T0gQkQmR9GAqisdtbiaPwb12VYxZ2Uw3bW/jekzTpUgJVlP PmST1DdHUZXAkQq1/E08x4KE/DWynYIfXAZ2sJRMVEHd/oeCgqb5DXJiQ7UK0zHo41cS Y+jrsYo6rI+MH+AJVsVizNrEv6lmnQeAKStc8= MIME-Version: 1.0 Received: by 10.229.191.71 with SMTP id dl7mr6735250qcb.184.1281312112404; Sun, 08 Aug 2010 17:01:52 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.229.251.6 with HTTP; Sun, 8 Aug 2010 17:01:52 -0700 (PDT) In-Reply-To: <201005161943.o4GJhnTo096839@svn.freebsd.org> References: <201005161943.o4GJhnTo096839@svn.freebsd.org> Date: Mon, 9 Aug 2010 02:01:52 +0200 X-Google-Sender-Auth: PQ85tywercMHlUk9f6Vo6UmT5aQ Message-ID: From: Attilio Rao To: Randall Stewart Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: src-committers@freebsd.org, John Baldwin , "Jayachandran C." , svn-src-all@freebsd.org, Joe Landers , sbruno@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r208165 - in head/sys: kern mips/conf mips/include mips/mips mips/rmi mips/rmi/dev/xlr X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Aug 2010 00:26:08 -0000 2010/5/16 Randall Stewart : > Author: rrs > Date: Sun May 16 19:43:48 2010 > New Revision: 208165 > URL: http://svn.freebsd.org/changeset/base/208165 > > Log: > =C2=A0This pushes all of JC's patches that I have in place. I > =C2=A0am now able to run 32 cores ok.. but I still will hang > =C2=A0on buildworld with a NFS problem. I suspect I am missing > =C2=A0a patch for the netlogic rge driver. > > =C2=A0JC check and see if I am missing anything except your > =C2=A0core-mask changes > Modified: head/sys/kern/subr_smp.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/subr_smp.c =C2=A0 =C2=A0Sun May 16 19:25:56 2010 =C2=A0= =C2=A0 =C2=A0 =C2=A0(r208164) > +++ head/sys/kern/subr_smp.c =C2=A0 =C2=A0Sun May 16 19:43:48 2010 =C2=A0= =C2=A0 =C2=A0 =C2=A0(r208165) > @@ -503,7 +503,10 @@ smp_topo_none(void) > =C2=A0 =C2=A0 =C2=A0 =C2=A0top =3D &group[0]; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_parent =3D NULL; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_child =3D NULL; > - =C2=A0 =C2=A0 =C2=A0 top->cg_mask =3D (1 << mp_ncpus) - 1; > + =C2=A0 =C2=A0 =C2=A0 if (mp_ncpus =3D=3D sizeof(top->cg_mask) * 8) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 top->cg_mask =3D -1; > + =C2=A0 =C2=A0 =C2=A0 else > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 top->cg_mask =3D (1 <<= mp_ncpus) - 1; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_count =3D mp_ncpus; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_children =3D 0; > =C2=A0 =C2=A0 =C2=A0 =C2=A0top->cg_level =3D CG_SHARE_NONE; > ... and this is why I particulary hate big commits with complete lack of technical details. This particulary chunk was supposed to fix a nasty and completely MI bug that some users have already met (kern/148698). The complete lack of details didn't help in identify the issue neither that it was a valuable fix. The fix is, however, improper (there is no clear relationship between the multiplication and why that happens) thus I would rather use what Joe has reported in the PR. Thanks, Attilio --=20 Peace can only be achieved by understanding - A. Einstein