From owner-svn-src-stable@freebsd.org Sun Mar 11 17:53:48 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89186F41690; Sun, 11 Mar 2018 17:53:48 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EF3CE76520; Sun, 11 Mar 2018 17:53:47 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w2BHrkpS074878; Sun, 11 Mar 2018 10:53:46 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w2BHrk7R074877; Sun, 11 Mar 2018 10:53:46 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201803111753.w2BHrk7R074877@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211 In-Reply-To: To: =?UTF-8?Q?Pint=C3=A9r=2C_Oliv=C3=A9r?= Date: Sun, 11 Mar 2018 10:53:46 -0700 (PDT) CC: rgrimes@freebsd.org, Eitan Adler , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers , svn-src-stable-11@freebsd.org, John Baldwin Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Mar 2018 17:53:48 -0000 > On Thu, Mar 8, 2018 at 12:51 PM, Pint?r, Oliv?r > wrote: > > > > > > > On Thu, Mar 8, 2018 at 12:18 AM, Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > >> > On 7 March 2018 at 09:37, John Baldwin wrote: > >> > > On Tuesday, March 06, 2018 06:46:37 PM Eitan Adler wrote: > >> > >> On 6 March 2018 at 08:26, John Baldwin wrote: > >> > >> > On Monday, March 05, 2018 07:13:59 PM Eitan Adler wrote: > >> > >> >> On 5 March 2018 at 10:08, John Baldwin wrote: > >> > >> >> > On Monday, March 05, 2018 07:54:58 AM Eitan Adler wrote: > >> > >> >> >> Author: eadler > >> > >> >> >> Date: Mon Mar 5 07:54:57 2018 > >> > >> >> >> New Revision: 330451 > >> > >> >> >> URL: https://svnweb.freebsd.org/changeset/base/330451 > >> > >> >> >> > >> > >> >> >> Log: > >> > >> >> >> MFC r306837: > >> > >> >> >> > >> > >> >> >> [net80211] extend the ieee80211_rx_stats struct to include > >> more information. > >> > >> >> > > >> > >> >> > Have you thought about the KBI implications of this change and > >> some of the > >> > >> >> > other changes you've merged? > >> > >> >> > >> > >> >> I do have a copy of the modules from 11.1 and have loaded them at > >> > >> >> various points in time after merging. That said, I am not perfect. > >> > >> >> Unfortunately, my -STABLE box did not have fully functioning > >> drivers > >> > >> >> before these changes so its difficult to test anything beyond > >> "loads > >> > >> >> and does not panic.". I havn't done so today yet, but that will > >> happen > >> > >> >> soon. > >> > >> >> > >> > >> >> Ensuring these things work through code inspection is certainly > >> > >> >> possible and I've skipped over several changes as a result. > >> > >> > > >> > >> > Loading a module doesn't alone doesn't actually test for breakage. > >> > >> > >> > >> I'm aware. In this case I should likely just revert this change since > >> > >> its a pretty blatant break. > >> > > > >> > > I suspect many of these changes for iwm, etc. are all intertwined so > >> I'm not > >> > > sure if you can leave out individual ones. > >> > > >> > Possibly. I do have iwm working on my laptop though. I also know of > >> > one open PR assigned to me w.r.t. a model I don't own. I'll be > >> > addressing it some time this week. > >> > >> I believe I also have a tester of stable/11 iwm patches avaliable, > >> he has an 8265? ^^^^ Its an 8565, my mistake. > >> > > > > At weekend I will test them. > > > > Sorry, -ENOTIME for 8265 this weekend, but it working fine (and much more > stable) with 7260. Thanks for keeping us informed. I am uncertain as to the state of iwm in stable/11, should the Intel 8565ac work, or not? I have exchanged an additional round of email with the volunteer tester, he says he is running an unmodified stable/11, now trying to find out if he is updating that regular or not. Hopefully we can have some test results soon. Thanks, -- Rod Grimes rgrimes@freebsd.org