Date: Sat, 24 Aug 2019 15:58:30 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 238780] converters/pdf2djvu: fix build with GCC-based architectures Message-ID: <bug-238780-7788-pATS5TFUZQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238780-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-238780-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238780 --- Comment #17 from Samy Mahmoudi <samy.mahmoudi@gmail.com> --- (In reply to Samy Mahmoudi from comment #11) > .if ${ARCH:Mmips*} || ${ARCH:Mpowerpc*} || ${ARCH} =3D=3D sparc64 > Is your GCC-architecture included in the previous conditionals ? Based on comment 16, I assume it is. (In reply to Piotr Kubaj from comment #16) > In fact, powerpc* on head soon switches to clang. Thanks for this information, I did not know that would happen soon, but...= =20 (In reply to Piotr Kubaj from comment #16) > This assumes that powerpc* uses GCC which won't hold true forever. ...the conditional expression was not meant to be immutable, e.g. to add new GCC-architectures when needed, or to remove the ones clang become functional on. Software sometimes needs to be maintained, even with the best software methodologies and practices. > Why not set USES=3Dcompiler:c++11-lang? This was the default under which you had to file a bug report, so this would only bring us back to Description (comment 0) and subsequent comments. Do y= ou mean USES=3Dcompiler:c++11-lib ? I am reading Mk/Uses/compiler.mk and will = give it a try. If this automatically chooses between clang and gcc depending on architecture, it would avoid us to have to maintain the conditional. This w= ould definitely be a better practice ! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238780-7788-pATS5TFUZQ>