From owner-freebsd-current@FreeBSD.ORG Mon Apr 22 21:53:46 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 188ADA03 for ; Mon, 22 Apr 2013 21:53:46 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by mx1.freebsd.org (Postfix) with ESMTP id CF3A917DE for ; Mon, 22 Apr 2013 21:53:45 +0000 (UTC) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.80.1) with esmtp (envelope-from ) id <1UUOgD-002izF-25>; Mon, 22 Apr 2013 23:53:45 +0200 Received: from e178184116.adsl.alicedsl.de ([85.178.184.116] helo=[192.168.0.128]) by inpost2.zedat.fu-berlin.de (Exim 4.80.1) with esmtpsa (envelope-from ) id <1UUOgC-000OcN-Td>; Mon, 22 Apr 2013 23:53:45 +0200 Subject: Re: CURRENT: /usr/src/sbin/newfs_nandfs/newfs_nandfs.c:89:18: error: no previous extern declaration for non-static variable From: "O. Hartmann" To: Ed Schouten In-Reply-To: References: <1366574922.38339.59.camel@thor.walstatt.dyndns.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-MlYMvKyDFXkz6AwnCGTc" Date: Mon, 22 Apr 2013 23:53:44 +0200 Message-ID: <1366667624.1416.12.camel@thor.walstatt.dyndns.org> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port X-Originating-IP: 85.178.184.116 Cc: FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2013 21:53:46 -0000 --=-MlYMvKyDFXkz6AwnCGTc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Mon, 2013-04-22 at 00:09 +0200, Ed Schouten wrote: > Hi, >=20 > 2013/4/21 O. Hartmann : > > /usr/src/sbin/newfs_nandfs/newfs_nandfs.c:83:18: error: no previous > > extern declaration for non-static variable > > 'user_files' [-Werror,-Wmissing-variable-declarations] > > struct file_info user_files[] =3D > > ^ >=20 > The following patch should fix this: >=20 > http://80386.nl/pub/nandfs-warns-6.txt >=20 > As of a couple of days ago, WARNS=3D6 requires that global variables > either have an external declaration or are marked static. As > newfs_nandfs only consists of a single C file, we can easily mark > these variables static. In this specific case it allowed the compiler > to find another peculiarity in the code, namely that the > seg_segsum_size variable is unused. >=20 > I'll commit this patch after I've done some testing. >=20 > Thanks, > -- > Ed Schouten Thank you very much. Oliver --=-MlYMvKyDFXkz6AwnCGTc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAABAgAGBQJRdbFoAAoJEOgBcD7A/5N8IFkIALDnCm7wNFBn7AJvMT6gLtaV FEfEnliIEy/sttIqZOdQS0t04+RZe5I8pIYMlQTPSdmVFU4mPUbFwY51T894Wd77 r/Vl64dPFqhXwek4/mKbLh3ibHTgIUAShU9iypWN/3cRY9mslqBUpuI6neSpJUh8 kBhzCHymJQAxb7ySXEBsczlDsX9HPUzYYcNDoXX0g1BLJU0fi4tLOlhG/tfgDG9n fkwfTNNDbViWGh6IEcUwctS8yx1kpeNFKcBaPKDDiR/u/lM6+XsJe76w/JkxcIOZ PVx1DNiB/ndaoWsPBAAyfhyr49fLYmXEE2O2Xbxj1GGleCjOQdd0recDsznTHXA= =hd2M -----END PGP SIGNATURE----- --=-MlYMvKyDFXkz6AwnCGTc--