From owner-freebsd-net@FreeBSD.ORG  Thu Jan  8 08:18:46 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 01FA0106566B
	for <freebsd-net@freebsd.org>; Thu,  8 Jan 2009 08:18:46 +0000 (UTC)
	(envelope-from yonyossef.lists@gmail.com)
Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.170])
	by mx1.freebsd.org (Postfix) with ESMTP id 54E6A8FC1B
	for <freebsd-net@freebsd.org>; Thu,  8 Jan 2009 08:18:44 +0000 (UTC)
	(envelope-from yonyossef.lists@gmail.com)
Received: by ug-out-1314.google.com with SMTP id 30so1458348ugs.39
	for <multiple recipients>; Thu, 08 Jan 2009 00:18:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:from:to:cc:references:subject
	:date:message-id:mime-version:content-type:content-transfer-encoding
	:x-mailer:thread-index:in-reply-to:x-mimeole;
	bh=d/OESLjEMandt5w2NyqqU82yrvl/69jI7XoITwltzRk=;
	b=AHRq5pcuSjYabIYaKlTPiC/418fndwPEdSJFoDm6/iNLGSM4/t6DA4PgGXBgBvOvww
	sADaGF7Dc1bhXjPeef1p7xuwyzIMxAsq3xRcp6vH37i4TiGr2utfrMNmwhPo4qjfqdrH
	rU4Dks0G8gjQVY8TLXIEcPx6zDQmp1fSqLyQs=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:references:subject:date:message-id:mime-version
	:content-type:content-transfer-encoding:x-mailer:thread-index
	:in-reply-to:x-mimeole;
	b=gSIk5KxDjnumWRkhh7gu9hOXBoHFNSqvrUJh3sR1C/ALOiJsKbklj+qLZDrsp1EPbs
	UoGAaA4y2h8Ogz/UqIWDgrT+sHRBc3o6pcO6oqTAeC50O90+aed3m01Nb2a4fcjM4nMJ
	iCnwRNnx1XbIN3gjCpqxJPR+Fxbfsbyjw69uI=
Received: by 10.67.40.6 with SMTP id s6mr3139494ugj.10.1231402724207;
	Thu, 08 Jan 2009 00:18:44 -0800 (PST)
Received: from mtllpt03 (DSL212-235-20-133.bb.netvision.net.il
	[212.235.20.133])
	by mx.google.com with ESMTPS id y6sm27996711uge.28.2009.01.08.00.18.42
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Thu, 08 Jan 2009 00:18:43 -0800 (PST)
From: "Yony Yossef" <yonyossef.lists@gmail.com>
To: "'Sam Leffler'" <sam@freebsd.org>,
	"Jack Vogel" <jfvogel@gmail.com>
References: <000001c970a8$3fa45240$220f000a@mtl.com>	
	<4964C2E9.1060301@bestunion.it>	
	<000001c970d9$4403e590$220f000a@mtl.com>	
	<4964EC4F.8030507@freebsd.org>
	<2a41acea0901071359w3f41465ajb8206cdef5b7b680@mail.gmail.com>
	<49652E25.9030705@freebsd.org>
Date: Thu, 8 Jan 2009 10:18:40 +0200
Message-ID: <000601c97169$b85717b0$220f000a@mtl.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 11
Thread-Index: AclxGEMroQ0DEzw2TpiyBNWaKlAhXAAUSMfw
In-Reply-To: <49652E25.9030705@freebsd.org>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350
Cc: Eitan Shefi <eitans@mellanox.co.il>, Angelo Turetta <aturetta@bestunion.it>,
	Yony Yossef <yonyossef.lists@gmail.com>, freebsd-net@freebsd.org
Subject: RE: VLAN interface management - unloading carrying driver hangs the
	machine
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jan 2009 08:18:46 -0000

> Jack Vogel wrote:
> >
> >
> > On Wed, Jan 7, 2009 at 9:54 AM, Sam Leffler <sam@freebsd.org 
> > <mailto:sam@freebsd.org>> wrote:
> >
> >     Yony Yossef wrote:
> >
> >             Yony Yossef wrote:
> >                
> >
> >                 /sbin/ifconfig vlan3653 create
> >
> >                 Problem is when I assign an IP to the vlan 
> interface.
> >                 In that case, unloading the driver results 
> in hanging
> >                 the host.
> >                  Does it sound familiar to anybody?
> >                      
> >
> >             Well, surely I'd expect problems by doing so.
> >             The correct way is to
> >
> >                    /sbin/ifconfig vlan3653 destroy
> >
> >             before unloading the driver.
> >
> >             Angelo.
> >                
> >
> >
> >         Thanks, I didn't know freebsd does not allow it.
> >
> >          
> >
> >     This seems wrong. Someone should disallow the driver
> >     detach/unload. Please file a PR about this so the issue 
> is not lost.
> >
> >     Sam
> >
> >
> > In many drivers, ahem, like mine, there is a test at detach and it 
> > will not allow it if there is a non-NULL trunk.
> >
> > Sounds like a broken driver needs to be fixed is all...
> >
> I don't agree; drivers should not be required to deal with 
> this.  If someone files a PR and assigns it to me I'll look at it.
> 
>     Sam
> 

I agree with Sam. There's no reason to leave this check to the driver.

Yony