From owner-cvs-src@FreeBSD.ORG Mon May 5 00:28:19 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C304337B401; Mon, 5 May 2003 00:28:19 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1510A43F3F; Mon, 5 May 2003 00:28:19 -0700 (PDT) (envelope-from scottl@btc.adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h457P2Z29041; Mon, 5 May 2003 00:25:02 -0700 Received: from hollin.btc.adaptec.com (hollin.btc.adaptec.com [10.100.253.56]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id AAA06711; Mon, 5 May 2003 00:28:11 -0700 (PDT) Received: from hollin.btc.adaptec.com (localhost [127.0.0.1]) h457PIQ5083626; Mon, 5 May 2003 01:25:18 -0600 (MDT) (envelope-from scottl@hollin.btc.adaptec.com) Received: (from scottl@localhost) by hollin.btc.adaptec.com (8.12.9/8.12.9/Submit) id h457PIkX083625; Mon, 5 May 2003 01:25:18 -0600 (MDT) (envelope-from scottl) Date: Mon, 5 May 2003 01:25:18 -0600 From: Scott Long To: Greg Lehey Message-ID: <20030505072517.GC83498@hollin.btc.adaptec.com> References: <200305050532.h455WFM1029824@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200305050532.h455WFM1029824@repoman.freebsd.org> User-Agent: Mutt/1.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinumconfig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2003 07:28:20 -0000 On Sun, May 04, 2003 at 10:32:15PM -0700, Greg Lehey wrote: > grog 2003/05/04 22:32:15 PDT > > FreeBSD src repository > > Modified files: > sys/dev/vinum vinumconfig.c > Log: > [...] This does not compile. Considering your recent statements on breaking code, and the well published fact that 5.1-BETA happens in less than 24 hours, I would appreciate if code was compile-tested before being checked in: cc -O -pipe -mcpu=pentiumpro -DVINUMDEBUG -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/dev -I@/../include -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -c /usr/src/sys/dev/vinum/vinumconfig.c /usr/src/sys/dev/vinum/vinumconfig.c:180: conflicting types for `give_plex_to_volume' @/dev/vinum/vinumext.h:73: previous declaration of `give_plex_to_volume' *** Error code 1 Stop in /usr/src/sys/modules/vinum. *** Error code 1