From owner-svn-src-head@freebsd.org  Sun Jul 10 19:15:31 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10B2BB845CC;
 Sun, 10 Jul 2016 19:15:31 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D1B061BC5;
 Sun, 10 Jul 2016 19:15:30 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u6AJFT0a095416;
 Sun, 10 Jul 2016 19:15:29 GMT (envelope-from mav@FreeBSD.org)
Received: (from mav@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u6AJFTLg095415;
 Sun, 10 Jul 2016 19:15:29 GMT (envelope-from mav@FreeBSD.org)
Message-Id: <201607101915.u6AJFTLg095415@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: mav set sender to mav@FreeBSD.org
 using -f
From: Alexander Motin <mav@FreeBSD.org>
Date: Sun, 10 Jul 2016 19:15:29 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r302529 - head/sys/dev/ntb
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jul 2016 19:15:31 -0000

Author: mav
Date: Sun Jul 10 19:15:29 2016
New Revision: 302529
URL: https://svnweb.freebsd.org/changeset/base/302529

Log:
  Remove callout_reset(link_work) from ntb_transport_attach().
  
  At that point link is quite likely not established yet, so messing with
  scratch registers is premature there.  Original commit message mentioned
  code diff reduction from Linux, but this line is not present in Linux now.

Modified:
  head/sys/dev/ntb/ntb_transport.c

Modified: head/sys/dev/ntb/ntb_transport.c
==============================================================================
--- head/sys/dev/ntb/ntb_transport.c	Sun Jul 10 18:28:15 2016	(r302528)
+++ head/sys/dev/ntb/ntb_transport.c	Sun Jul 10 19:15:29 2016	(r302529)
@@ -394,7 +394,6 @@ ntb_transport_attach(device_t dev)
 	nt->link_is_up = false;
 	NTB_LINK_ENABLE(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);
 
-	callout_reset(&nt->link_work, 0, ntb_transport_link_work, nt);
 	if (enable_xeon_watchdog != 0)
 		callout_reset(&nt->link_watchdog, 0, xeon_link_watchdog_hb, nt);