From nobody Wed Oct 4 13:43:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S0wrl4Jrdz4vy6q; Wed, 4 Oct 2023 13:43:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S0wrl3MGyz3ZV6; Wed, 4 Oct 2023 13:43:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696427031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KfVa7/K29DLL/m7xWZKxldsc0pBv+yd4ItMiYbOfZYE=; b=gOVdCEVGYP+6PScpGNY0eOl7UVKXEoCQQ7HJRlFm/i1JBKUZhvcuUwTw7JEWeLGKtt4E/G hykWJFBTc5YvSNZNo2PfT0OUZjxYL5rPlD+Nb8qCncTn5x/Ul6yFoiWCOCBgoweG4VeD41 ekmFo5HP8g/iWfugobQP88AID4VegQNFJcYIYsxgnFCiFdKyi73gWSLWUn+fvJP9MWseqW YGcSwjBBlgLZym5Snq5kt+bp8nvLxOYqsPnj3CxhL98N7lVP6gyMXqGc+tEgoM/OhnH2kY sm1lSFAuzKoLZYmwMZs4Quohcny+9J1GTrDGQDQ8iJBN2xwShwee/7rQ/XlVlA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696427031; a=rsa-sha256; cv=none; b=t3GfJbKitXZj+YSR2zK6HpKwO/hZ2CghM6ILEQclrhjYTcFiEE4rXrz4+nKwnUcR5Er3ng mGVkGQ9tV6n47hqmCIjeYa3tSRNg2QWIXgvn+LgC4uXVFeKq6kDnDskZeC6ldxy6Ok1Sgr qYAbjId8D4gitcfzTGtE5vnlDNCUlCob0YhE2ya2Hh/DR/8rNoeV1FZBPR2oxAIeQTRXIH eWNJ/NfZZFNNlnT1st0foky3dD/vcLo9etzE4yP5cf//v1DLm7eQH+g/yPgfBL7UeZW5az nmFYL3IITMxnpXhjnCcrWw+BUrmJeK25Qi6BjbSQMJTGH3dUZVsSKGCd9ytTVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696427031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KfVa7/K29DLL/m7xWZKxldsc0pBv+yd4ItMiYbOfZYE=; b=YNE4HWw0oBEYeqKPBUfLWcu1k0qztmzXlRAA5FsfM5drF/WZ8rEC2wWZsUiGtsHUJQC8RJ Xjigo6fEJ6XrtUdtL+qOMs/L1CA9F8ECbsqW05ExUFihOyjb9nH7SWH7sSgT4bR+o9zj2M 4LVKWrBH73pG4T2wiZYb+l4muHJaJI+5ZhmFTVPiSyzn7+/ZA0TbiKfiWrG2LbX3NE2rR4 0nBHXbeMDIouL/2WVwuJUxNmlCfewCchiyoH9GbHyhJ8NV1+cJmdqx3Rl+O35kUMiduZDj 7uARsv5hUepLDveNqFZqjExh+NPCAaSXLNy11BLEsyoN7GBDdpfwGNipbLHtuQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S0wrl29Zgzfvk; Wed, 4 Oct 2023 13:43:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 394DhpYb020206; Wed, 4 Oct 2023 13:43:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 394Dhpw3020203; Wed, 4 Oct 2023 13:43:51 GMT (envelope-from git) Date: Wed, 4 Oct 2023 13:43:51 GMT Message-Id: <202310041343.394Dhpw3020203@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 0074d0551ded - stable/14 - makefs/zfs: Remove a nonsensical comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0074d0551ded1652155a23c6a8d04043c8ede1fd Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=0074d0551ded1652155a23c6a8d04043c8ede1fd commit 0074d0551ded1652155a23c6a8d04043c8ede1fd Author: Mark Johnston AuthorDate: 2023-09-27 22:21:37 +0000 Commit: Mark Johnston CommitDate: 2023-10-04 13:42:23 +0000 makefs/zfs: Remove a nonsensical comment When populating files, makefs needs to copy their contents into userspace in order to compute a checksum, so copy_file_range(2) is out of the question. Though, it could possibly be used when building other types of filesystems. MFC after: 1 week Sponsored by: The FreeBSD Foundation (cherry picked from commit 60c95af88f6a63fb7c2c86c6ff9c18743f6bbf0d) --- usr.sbin/makefs/zfs/fs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/usr.sbin/makefs/zfs/fs.c b/usr.sbin/makefs/zfs/fs.c index a4968d5f91e8..0d85ea8eb9d8 100644 --- a/usr.sbin/makefs/zfs/fs.c +++ b/usr.sbin/makefs/zfs/fs.c @@ -551,8 +551,6 @@ fs_populate_file(fsnode *cur, struct fs_populate_arg *arg) /* * Fill up our buffer, handling partial reads. - * - * It might be profitable to use copy_file_range(2) here. */ sofar = 0; target = MIN(size - foff, (off_t)bufsz);