From nobody Sat Mar 28 05:56:25 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fjRbM185jz6XbTt for ; Sat, 28 Mar 2026 05:56:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fjRbL5Mpzz3qfH for ; Sat, 28 Mar 2026 05:56:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774677390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bOWX3DzgcFcbbqy3wJ8ONU2D6ihqoyi1HgC9HVbPvJ0=; b=eyaPQnHEA/ymbqR1Te9OJxMvaTL0Cmu9vSW9kL0IghR87bXuKveEC5o4NsCT3/bst5KPDM yTraWrRHrMpPyzumBUMg1OstVIIrt7T0EON70LlvMT7S9WRn1a0EpbZigxu/7OQU+9wHgL vtqnrW9ub2CTB3i6ch2NBSvApjxv3wl82TQoIENoA5fgkgaeM02wWuX3gy/Tozva6Qv8T8 FvffkFyRsZoxYQ/mkcUc54YY2WGTB7oRxWLej3sFG4lEtNTog1Fy+PvBH8clOBrhWeF4bg K1beh5NuQ4wx7zPZE64LeISj860HMb3shCBgf72YvJ3laj5LtyQmR9LSaT8kDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774677390; a=rsa-sha256; cv=none; b=h5ff30KadZUE7bB6TJ9joVKr0inwl9TvNngd0V4xCRWZbtKv3O6gLM5HS1s8S2fF4nEF0f LuMAowRTFwpEkvhnGyfn25gkJdp1E+xTHybEu2AV+PB1gRHrjOD8aqcmgiyI6VFKyF0uj/ C1zeywXNVPgs9L+PrZbbV4fNTq7x5p1+uNAzYGhuYMeTZCnSsYMDWP2opXmfYkywjqRzvb YpeuXQ5sK8tWJp2vSBfio+tlvHWV3MGWFD9iCJiOiZm+Qy+trlu32a3wrdwmrLIcErVqNI dS1+1FLhijfo4U62Jy+gulSNIW21dWiLXA1fAKns3eyz+MJN5ydPzMwivXMrRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774677390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bOWX3DzgcFcbbqy3wJ8ONU2D6ihqoyi1HgC9HVbPvJ0=; b=DMsREEdF/L/5XGe8J5iRwDbOtSCOV67kMYfLgbv3dYhYSWsAZ9ZqZyaxJ8GJDtBzt5LIbm MEw4LIauUHss4uHmIWICqZ7PNrV67mv1XJGgvwiLWI7+acKIwjG72lpKI+HvH6y+mqqJsR xoOgmyZLWVjqbXRQWAoF8CHSsFbHc3LZvJcF5rG+3PwXsHoIFMoqRPNuF1FimhNhxtCUbq NtouFEhNhObGfPx8ZGGnaTARn16Dll3Yp9kqRZ3BoHSNwAxFdRfq8SwGOaVxF0r3/7YZTq e7fXcO/GBJ+vhZL0g8j2u16bIHgg3FJ2jOp3+5AAw69HDx/14Rsnjlcv45HRKA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fjRbL4vwJz1BmR for ; Sat, 28 Mar 2026 05:56:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40098 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 28 Mar 2026 05:56:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: f350063a251c - main - clapic_handle_intr: KASSERT isrc != NULL List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f350063a251c9da0c5ce437eb4c44a2d716b673e Auto-Submitted: auto-generated Date: Sat, 28 Mar 2026 05:56:25 +0000 Message-Id: <69c76d89.40098.14c72c7b@gitrepo.freebsd.org> The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=f350063a251c9da0c5ce437eb4c44a2d716b673e commit f350063a251c9da0c5ce437eb4c44a2d716b673e Author: Colin Percival AuthorDate: 2026-03-14 01:03:44 +0000 Commit: Colin Percival CommitDate: 2026-03-28 05:52:44 +0000 clapic_handle_intr: KASSERT isrc != NULL If an interrupt arrives at a CPU which isn't expecting that particular vector, intr_lookup_source will return an isrc of NULL and we'll panic when intr_execute_handlers increments *isrc->is_count. Place a KASSERT a few nanoseconds earlier in order to leave some more breadcrumbs for the next person to trip over this behaviour. Tested on: EC2 r8i.96xlarge MFC after: 3 weeks Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D55851 --- sys/x86/x86/local_apic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/x86/x86/local_apic.c b/sys/x86/x86/local_apic.c index 8a8fb8ef41f6..888fd266d364 100644 --- a/sys/x86/x86/local_apic.c +++ b/sys/x86/x86/local_apic.c @@ -1445,6 +1445,9 @@ lapic_handle_intr(int vector, struct trapframe *frame) isrc = intr_lookup_source(apic_idt_to_irq(PCPU_GET(apic_id), vector)); + KASSERT(isrc != NULL, + ("lapic_handle_intr: vector %d unrecognized at lapic %u", + vector, PCPU_GET(apic_id))); intr_execute_handlers(isrc, frame); }